New issue
Advanced search Search tips

Issue 741220 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

FileNetLogObserver should not crash when it fails to open an output file

Project Member Reported by eroman@chromium.org, Jul 12 2017

Issue description

Doesn't account for failures in base::OpenFile().
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a96b043bda58587732f846e40e25805b108ffe20

commit a96b043bda58587732f846e40e25805b108ffe20
Author: Eric Roman <eroman@chromium.org>
Date: Wed Jul 12 21:46:18 2017

Make FileNetLogObsever not crash when it fails to open output files.

Bug:  741220 
Change-Id: Ia066158712e5980459af17d602795c4997a90b2f
Reviewed-on: https://chromium-review.googlesource.com/567799
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486096}
[modify] https://crrev.com/a96b043bda58587732f846e40e25805b108ffe20/net/log/file_net_log_observer.cc
[modify] https://crrev.com/a96b043bda58587732f846e40e25805b108ffe20/net/log/file_net_log_observer.h
[modify] https://crrev.com/a96b043bda58587732f846e40e25805b108ffe20/net/log/file_net_log_observer_unittest.cc

Comment 3 by eroman@chromium.org, Jul 12 2017

Status: Fixed (was: Assigned)

Sign in to add a comment