New issue
Advanced search Search tips

Issue 741204 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

[Autofill][Accessibility] Add a new address fields don't show autofill suggestion

Project Member Reported by michaelbai@chromium.org, Jul 11 2017

Issue description

- Turn on the accessibility
Go to phone settings-> Accessibility -> TalkBack ->ON/OFF  (for some phones like Samsung it would be settings-> Accessibility -> Vision -> TalkBack ->ON/OFF).

- Launch chrome android to access amazon.com and sign in
- Goto your account -> Manage address book -> add new address.
- Autofill didn't work

Expect autofill to work

From my investigation,  PageClickTracker::DidReceiveLeftMouseDownOrGestureTapInNode() isn't called.
 
Labels: triage-andrew
Cc: paulmiller@chromium.org
Labels: -Pri-3 Pri-1
bumping priority to match internal bug 65053465
Could you please specify the Chrome version? I was unable to reproduce this on either stable (60.0.3112.107) or canary (62.0.3194.0). I attached a screenshot taken from Pixel XL using Chrome Canary.

Screenshot_20170825-172405.png
198 KB View Download

Nexus 6p
Android OPM1.170824.002
Chrome Stable: 61.0.3163.51

I think the key part is GMS, as I understand talkback is part of GMS. if you flash to OPM1.170824.002, you should get the same GMS as mine.

Let me know if you have difficult to reproduce it.

Comment 5 by sgu...@chromium.org, Sep 27 2017

Cc: -sgu...@chromium.org
Could we have some update on this issue? 

Please note that M63 Stable approaching soon in 3 weeks. So,  if we want have this change on M63  we need to fix and merge this change soon.

Thanks!
Owner: ekaramad@chromium.org
Re: #4, TalkBack is not part of GMS.
It has been while with updates on this issue, could we have some updates, please?
Thanks!
Status: Assigned (was: Untriaged)
I still cannot reproduce this when trying on Chrome 66, Nexus 6 Android 5.1 and setting Talk Back to ON.

Without talk back, the following WebAutofillClient methods get called when I tap inside <input>.

UserGestureObserved
UserGestureObserved
DidReceiveLeftMouseDownOrGestureTapInNode
FormControlElementClicked

With Talkback ON I see the same method calls except that I need to double tap to instead of single tap.

That being said I had done some refactoring work while adding support for OOPIFs but it is unrelated to any caller code for ChromeClientImpl::OnMouseDown.

If as description suggests WebAutofillClient::DidReceiveMouseDownOrGestureTapInNode is not called then either
1- ChromeClientImpl::OnMouseDown is not called.
2- The Node passed down does not have a LocalFrame.
3- The WebLocalFrameImpl does not have a WebAutofillClient.

This would seem like a hit testing issue which I am not familiar with. 


michaelbai@: I am currently a bit stretched and also not familiar with the code around Android+AutofillClient. Would you be able to re-triage this bug?
Owner: michaelbai@chromium.org
Cc: michaelbai@chromium.org
Owner: ekaramad@chromium.org
ekaramad@ I am not familiar with accessibility feature, and Autofill doesn't has specific code for autofill, could you confirm 'double tap' behavior consistent with Android platform? If so, we can close this issue.


Sorry for the delayed response.

I can confirm I could not reproduce the issue on Canary on neither Pixel XL running 
 OPM 1.171019.021 Android 8.1 nor Nexus 6 running Android 5.1.1 LMY49S 3276206 dev-keys which is a developer build. I did not however try the OPM1.170824.002 which is mentioned in comment #4.

michaelbai@: Are you still able to try it on OPM you mentioned in comment #4 and see whether the issue exists on Canary?
Status: WontFix (was: Assigned)
I am closing the bug per comments #12 and #13. Please undo if the bug persists on specific OPM.

Sign in to add a comment