New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741201 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Downloads home items jumping around

Project Member Reported by talo@chromium.org, Jul 11 2017

Issue description

Chrome Version: Chrome Stable 59.0.3071.125
OS: Android

What steps will reproduce the problem?
(1) Download several pages / files
(2) Open downloads home
(3) Notice items moving around in the list before being rendered

What is the expected result?
(3) Items appear in list with no movement.

Happy to stop by and show you on my device as well! Just let me know!
 
Cc: jming@chromium.org
+jming@.  Can you and Shakti take a look?

Comment 2 by jming@chromium.org, Jul 13 2017

This video that talo@ sent me makes it seem like this is happening because the two types of downloads (offline pages vs images/etc) are loading at different rates, causing a switch in the order when the offline pages finally load.

https://drive.google.com/a/google.com/file/d/0BwltPzKKkOFqRnlRZDJTSk90WUU/view?usp=sharing
videoplayback.mp4
2.1 MB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a21cde6f20ba9f62d2f7702360e045d6f4ebbab

commit 9a21cde6f20ba9f62d2f7702360e045d6f4ebbab
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Fri Jul 14 01:41:06 2017

Download Home : Fixed an issue in list initialization

Since the backends for downloads and offline pages load asynchrously,
the DownloadHistoryAdapter waits for items from both backends to be
ready. There was a bug where this was not happening and which resulted
in download items shifting down when offline pages are added.
This CL fixes the bug.

Bug:  741201 
Change-Id: I45b58179721b79adc93bf2018dae3698babe2f17
Reviewed-on: https://chromium-review.googlesource.com/571187
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486614}
[modify] https://crrev.com/9a21cde6f20ba9f62d2f7702360e045d6f4ebbab/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

Status: Fixed (was: Untriaged)

Sign in to add a comment