New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741195 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Translation resulting failing presubmit

Project Member Reported by dimu@chromium.org, Jul 11 2017

Issue description

I'm trying to upload the translation result

https://chromium-review.googlesource.com/c/565350

It's failing linux_chromium_chromeos_rel_ng compile:

python ../../tools/grit/grit.py -i ../../chrome/app/generated_resources.grd build -o gen/chrome --depdir . --depfile gen/chrome/generated_resources_stamp.d --write-only-new=1 --depend-on-stamp -D _chromium -E CHROMIUM_BUILD=chromium -D chromeos -D scale_factors=2x -D toolkit_views -D use_aura -D use_ash -D use_nss_certs -D enable_app_list=true -D enable_background=true -D enable_extensions=true -D enable_google_now=false -D enable_hangout_services_extension=false -D enable_hotwording=false -D enable_plugins=true -D enable_print_preview=true -D enable_printing=true -D enable_service_discovery=true -D enable_webrtc=true -D enable_vr=false -D mac_views_browser=false -D safe_browsing_mode=1 -D use_vulcanize=true -f ../../tools/gritsettings/resource_ids --assert-file-list=obj/chrome/app/generated_resources_expected_outputs.txt
ERROR: 'kn' translation of message id 6516162730608508544 does not match
Exception during parsing of resources/generated_resources_kn.xtb
Error processing node <?xml version="1.0" encoding="UTF-8"?>
<file lang="kn" path="resources/generated_resources_kn.xtb" />
Traceback (most recent call last):
  File "../../tools/grit/grit.py", line 15, in <module>
    grit.grit_runner.Main(sys.argv[1:])
  File "/b/c/b/linux_chromeos/src/tools/grit/grit/grit_runner.py", line 268, in Main
    toolobject.Run(options, args[1:])
  File "/b/c/b/linux_chromeos/src/tools/grit/grit/tool/build.py", line 265, in Run
    self.res.RunGatherers()
  File "/b/c/b/linux_chromeos/src/tools/grit/grit/node/misc.py", line 512, in RunGatherers
    node.RunPostSubstitutionGatherer(debug=debug)
  File "/b/c/b/linux_chromeos/src/tools/grit/grit/node/io.py", line 51, in RunPostSubstitutionGatherer
    target_platform=target_platform)
  File "/b/c/b/linux_chromeos/src/tools/grit/grit/xtb_reader.py", line 138, in Parse
    xml.sax.parse(xtb_file, handler)
  File "/usr/lib/python2.7/xml/sax/__init__.py", line 33, in parse
    parser.parse(source)
  File "/usr/lib/python2.7/xml/sax/expatreader.py", line 107, in parse
    xmlreader.IncrementalParser.parse(self, source)
  File "/usr/lib/python2.7/xml/sax/xmlreader.py", line 123, in parse
    self.feed(buffer)
  File "/usr/lib/python2.7/xml/sax/expatreader.py", line 210, in feed
    self._parser.Parse(data, isFinal)
  File "/usr/lib/python2.7/xml/sax/expatreader.py", line 307, in end_element
    self._cont_handler.endElement(name)
  File "/b/c/b/linux_chromeos/src/tools/grit/grit/xtb_reader.py", line 78, in endElement
    self.callback(self.current_id, self.current_structure)
  File "/b/c/b/linux_chromeos/src/tools/grit/grit/clique.py", line 235, in Callback
    self.FindCliqueAndAddTranslation(translation, lang)
  File "/b/c/b/linux_chromeos/src/tools/grit/grit/clique.py", line 127, in FindCliqueAndAddTranslation
    clique.AddTranslation(translation, language)
  File "/b/c/b/linux_chromeos/src/tools/grit/grit/clique.py", line 474, in AddTranslation
    assert False
AssertionError

This translation is for message

https://chromium.googlesource.com/chromium/src/+blame/32f99d7e474d48ae4b80918e453e80991388a450/chrome/app/bookmarks_strings.grdp#434

calamity@, would you please take a look? Thank you!



 
Cc: tsergeant@chromium.org
The translation is missing the placeholder.

The original message is "'<ph name="DELETED_ITEM_NAME">$1</ph>' has been deleted" but the translation in kn doesn't have the $1 placeholder in it.

Comment 2 by dimu@chromium.org, Jul 12 2017

Cc: calamity@chromium.org
Owner: chiaravanone@chromium.org
Thank you calamity@!


chiaravanone@, would you please help to check the translation result for the missing placeholder.

The message is:
{COUNT,plural, =1{{DELETED_ITEM_NAME} ಅನ್ನು ಅಳಿಸಲಾಗಿದೆ}one{# ಬುಕ್‌ಮಾರ್ಕ್‌ಗಳನ್ನು ಅಳಿಸಲಾಗಿದೆ}other{# ಬುಕ್‌ಮಾರ್ಕ್‌ಗಳನ್ನು ಅಳಿಸಲಾಗಿದೆ}}

The message id should be 3627305900644900556, but when I look it up in TC it is a different message.

Comment 3 Deleted

Comment 4 by gov...@chromium.org, Jul 12 2017

This is currently blocking translation run on Master/trunk (M61).

Comment 5 by gov...@chromium.org, Jul 12 2017

Labels: OS-All
Message format getting restructured in https://chromium-review.googlesource.com/c/572478/.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75ca910c662e9ff192666f24c78d94be25b92f93

commit 75ca910c662e9ff192666f24c78d94be25b92f93
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Jul 18 02:15:18 2017

[MD Bookmarks] Separate single vs plural messages in toasts.

This CL separates the single and plural messages for copying and deleting
items. This is necessary because mixing $1 style placeholders with
ICU style plural formatting was providing translators with a string that
excluded the placeholder. This then broke when the translated string
was fed into a build, because it was missing the placeholder.

Bug:  741195 
Change-Id: Ib4bb619081282c9b497c7363c1a2b72252e3252f
Reviewed-on: https://chromium-review.googlesource.com/572478
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487346}
[modify] https://crrev.com/75ca910c662e9ff192666f24c78d94be25b92f93/chrome/app/bookmarks_strings.grdp
[modify] https://crrev.com/75ca910c662e9ff192666f24c78d94be25b92f93/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/75ca910c662e9ff192666f24c78d94be25b92f93/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc

Comment 8 by gov...@chromium.org, Jul 26 2017

URGENT - PTAL.
Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the M61 branch #3163 ASAP to have enough baking time in Beta before Stable promotion. Thank you!

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD

Sign in to add a comment