Some way to re-use the same shared memory for multiple DataPipes |
||||||||
Issue descriptionNo idea how crazy this idea would be, but in https://chromium-review.googlesource.com/c/558192/13/storage%252Fbrowser%252Fblob%252Fblob_transport_strategy.cc#132 brought up some concerns about repeatedly creating shared memory segments (because of multiple DataPipes), where the old code would reuse the same shared memory segment for all. So some way to pass the shared memory associated with one DataPipe to another might be a solution there. Not sure how it would work though, since at the point where you would want to "take back" the shared memory from one pipe to give it to another pipe you only have one end of the pipe, so code would have to be really careful to not somehow end up with multiple consumers and/or producers using the same shared memory at the same time.
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Nov 8 2017
Setting Internals>Services>Storage to all children of issue 611935
,
May 22 2018
this doesn't block canary.
,
May 22 2018
not related to network service.
,
Dec 4
mek@: does this seem to be a useful feature?
,
Dec 4
No idea how bad the overhead is of creating new shared memory regions over and over. Probably in the general case not much. So I guess the main thing here is if at some point we do decide to replace data pipes with some other mechanism built on top of other mojo primitives (which I think was the proposed solution whenever the suggestion to add new functionality to data pipes is brought up) this might be something to keep in mind.
,
Dec 11
,
Dec 12
OK, thanks. I'm gonna close this then. I think two things are true: 1. We do ton of shared memory allocation all over the place, and I am not aware of any evidence that this is a performance issue. 2. The ship has pretty much sailed on leaving data pipe in the low-level Mojo API as a first-class primitive. So I'd say if a situation comes up where we're actually impacted by allocation performance then this concern would naturally arise again. For now I'd rather clear it from the backlog. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dmu...@chromium.org
, Jul 17 2017