New issue
Advanced search Search tips

Issue 741147 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 709289



Sign in to add a comment

Add test_application_name property to create_bundle target of GN

Project Member Reported by liaoyuke@chromium.org, Jul 11 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/148fef685ebaea6f26c2b60b7006e9b7f711d228

commit 148fef685ebaea6f26c2b60b7006e9b7f711d228
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jul 13 21:35:24 2017

[iOS] Add xcode_test_application_name property to create_bundle target.

This CL adds xcode_test_application_name to create_bundle target so 
that the relationship between xcode unit or ui test target and test 
application target can be specified in BUILD files instead of being 
identified by parsing target names in GN.

Bug:  741147 , 709289
Change-Id: Idf0cb700b300d80d49803dae33eb90c87c0e41a0
Reviewed-on: https://chromium-review.googlesource.com/566587
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486482}
[modify] https://crrev.com/148fef685ebaea6f26c2b60b7006e9b7f711d228/tools/gn/bundle_data.h
[modify] https://crrev.com/148fef685ebaea6f26c2b60b7006e9b7f711d228/tools/gn/create_bundle_target_generator.cc
[modify] https://crrev.com/148fef685ebaea6f26c2b60b7006e9b7f711d228/tools/gn/create_bundle_target_generator.h
[modify] https://crrev.com/148fef685ebaea6f26c2b60b7006e9b7f711d228/tools/gn/docs/reference.md
[modify] https://crrev.com/148fef685ebaea6f26c2b60b7006e9b7f711d228/tools/gn/functions_target.cc
[modify] https://crrev.com/148fef685ebaea6f26c2b60b7006e9b7f711d228/tools/gn/variables.cc
[modify] https://crrev.com/148fef685ebaea6f26c2b60b7006e9b7f711d228/tools/gn/variables.h
[modify] https://crrev.com/148fef685ebaea6f26c2b60b7006e9b7f711d228/tools/gn/xcode_writer.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82cd07781b74cde019826c73e9706f9c113902b7

commit 82cd07781b74cde019826c73e9706f9c113902b7
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Aug 16 15:28:17 2017

[iOS] Clean up xcode_test_application_name usages in XcodeWriter.

https://chromium-review.googlesource.com/c/566592 This CL uses
test_application_name in BUILD files to specify the relationship
between XCTest target and corresponding test application target.
So, clean up the code in XcodeWriter.

Bug:  741147 , 709289
Change-Id: I4ce05f98c96bb05cf7cba1d1b67651996343c995
Reviewed-on: https://chromium-review.googlesource.com/614748
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494791}
[modify] https://crrev.com/82cd07781b74cde019826c73e9706f9c113902b7/tools/gn/xcode_writer.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d270571c2281f988bd2ba1fdf2507669e7ce7959

commit d270571c2281f988bd2ba1fdf2507669e7ce7959
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Aug 16 15:30:55 2017

[iOS] Use xcode_test_application_name in BUILD files.

This CL uses xcode_test_application_name in BUILD files to specify the
relationship between XCTest target and corresponding test application
target.

Bug:  741147 , 709289
Change-Id: I720280d623c5d668f920a544e41e2833ca305552
Reviewed-on: https://chromium-review.googlesource.com/566592
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494792}
[modify] https://crrev.com/d270571c2281f988bd2ba1fdf2507669e7ce7959/build/config/ios/rules.gni

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bafca0f82098a1e000bbca31a47b8b43834f55c4

commit bafca0f82098a1e000bbca31a47b8b43834f55c4
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Aug 16 15:48:21 2017

[iOS] Clean up xcode_extra_attributes usages in XcodeWriter.

https://chromium-review.googlesource.com/c/567619 assigns values to
xcode_extra_attributes in BUILD files, so clean up the hard-coded
values in GN.

Bug:  741147 , 709289
Change-Id: I564fa63f258fe3ade29dbeeb7e08b1876d7abcd8
Reviewed-on: https://chromium-review.googlesource.com/614864
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494800}
[modify] https://crrev.com/bafca0f82098a1e000bbca31a47b8b43834f55c4/tools/gn/xcode_writer.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c775957071a0c19b8e39ec1087cf8daefe9d00b

commit 7c775957071a0c19b8e39ec1087cf8daefe9d00b
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Aug 16 16:05:21 2017

[iOS] Use extra_attributes in BUILD files.

This CL uses extra_attributes in BUILD files so that these hard-coded
values can be removed from GN.

Bug:  741147 , 709289
Change-Id: I2c8a766d7e571fc898277133d343e2e1c0e8028d
Reviewed-on: https://chromium-review.googlesource.com/567619
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494804}
[modify] https://crrev.com/7c775957071a0c19b8e39ec1087cf8daefe9d00b/build/config/ios/rules.gni

Sign in to add a comment