New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741133 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 678663



Sign in to add a comment

Add automated regression test for power usage of background tab video playback

Project Member Reported by crouleau@chromium.org, Jul 11 2017

Issue description

Add automated regression test for power/memory/cpu usage of background tab video playback.
 
Cc: mlamouri@chromium.org
Labels: OS-All
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d91823c73e38ab53f22984d88c8f4a30cb52eda9

commit d91823c73e38ab53f22984d88c8f4a30cb52eda9
Author: Caleb Rouleau <crouleau@google.com>
Date: Wed Jul 12 19:07:50 2017

Add performance test for background video playback.

This will give us BattOr power measurements to use to assess the benefits of the optimizations.


Bug:  741133 
Change-Id: I49ce5c302e4b30cb4a963b4322bddaef578a6922
Reviewed-on: https://chromium-review.googlesource.com/566996
Commit-Queue: Caleb Rouleau <crouleau@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486045}
[modify] https://crrev.com/d91823c73e38ab53f22984d88c8f4a30cb52eda9/tools/perf/page_sets/tough_video_cases.py

The above code solves this problem for desktop, but the same code does not work for Android because the feature on Android is behind a flag (--disable-media-suspend). This cannot be trivially implemented for Android because we cannot set a flag for a single page on Android: we have to set the flag either at the benchmark level or at the measurement level. 

The blocking bug for this is https://github.com/catapult-project/catapult/issues/3863.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d00569c2ec14b3a4aa184c27af14c37381b0b08b

commit d00569c2ec14b3a4aa184c27af14c37381b0b08b
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Fri Sep 22 19:19:49 2017

Fix background playback telemetry perf test for Android.

Bug:  741133 
Change-Id: I5c410da6f4fde8886b30d8f739ff365cbf22d49e
Reviewed-on: https://chromium-review.googlesource.com/667500
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#503818}
[modify] https://crrev.com/d00569c2ec14b3a4aa184c27af14c37381b0b08b/tools/perf/benchmarks/media.py
[modify] https://crrev.com/d00569c2ec14b3a4aa184c27af14c37381b0b08b/tools/perf/page_sets/tough_video_cases.py

Status: Fixed (was: Started)
This is fixed, but we should verify that the numbers on https://chromeperf.appspot.com/report?sid=4b3ec844421ebb4628bcfc06235d72efdb188f2424bb5f3cf96fa97da50733fc end up being what we expect. (They should go up now that playback won't be completely suspended on Android for background test.)

Sign in to add a comment