Closing the tab containing the player removes the player from a currently-displayed list in chrome://media-internals |
||
Issue descriptionRepro steps (tip-of-tree linux local debug build circa r485695): 1) Open a window, browse to chrome://media-internals 2) Open another window, browse to, eg, youtube and start playing a video 3) Observe the media player is listed in chrome://media-internals 3a) (Not necessary for repro, but shows how severe this issue is): Select the player in chrome://media-internals to see its log details) 4) Close the youtube tab. Expected: the currently-displayed player (and its log if step 3a was done) should still show in the already-open view in chrome://media-internals Actual: the player entry (and its log) disappear from the already-open view in chrome://media-internals.
,
Jul 11 2017
More info: when I used Chrome task manager in step 4 to end the YT render process, I got (expected) a sad tab in the YT tab, but the player entry *did not* disappear.
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b26585d80259af0dec30ac33a4cc76664e10a6ef commit b26585d80259af0dec30ac33a4cc76664e10a6ef Author: Dan Sanders <sandersd@chromium.org> Date: Wed Jul 12 23:51:30 2017 media: Don't remove players from chrome://media-internals on process exit. As long as chrome://media-internals is open, it should preserve log entries. Log entries are still removed from the backing store, so these players will be removed if the page is reloaded. This CL also changes the trigger for backing store removal to include tab crashes. Previously there was no reliable way to remove a logs for a player from a crashed tab, which is problematic if the tab is incognito. Bug: 741132 Change-Id: I92b152fa6578c3728ab22a45786e188d93fb87f2 Reviewed-on: https://chromium-review.googlesource.com/567644 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#486159} [modify] https://crrev.com/b26585d80259af0dec30ac33a4cc76664e10a6ef/content/browser/media/media_internals.cc [modify] https://crrev.com/b26585d80259af0dec30ac33a4cc76664e10a6ef/content/browser/media/media_internals_proxy.cc [modify] https://crrev.com/b26585d80259af0dec30ac33a4cc76664e10a6ef/content/browser/media/media_internals_proxy.h [modify] https://crrev.com/b26585d80259af0dec30ac33a4cc76664e10a6ef/content/browser/resources/media/main.js [modify] https://crrev.com/b26585d80259af0dec30ac33a4cc76664e10a6ef/content/test/data/media/webui/integration_test.html
,
Mar 8 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by wolenetz@chromium.org
, Jul 11 2017Labels: OS-All
Owner: sande...@chromium.org
Status: Assigned (was: Untriaged)