New issue
Advanced search Search tips

Issue 741115 link

Starred by 2 users
Status: Fixed
Owner:
l...@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: ctrl+shift+B should disable breakpoints similar to shift+click in gutter

Project Member Reported by l...@chromium.org, Jul 11 2017 
When a JS file is open in Sources, clicking on a line number in the gutter can toggle the presence of a breakpoint.  Holding down shift and clicking the gutter will disable the breakpoint.

Ctrl+B mirrors the gutter click, toggling breakpoint on the current line.

However, Ctrl+Shift+B does not mirror gutter click+shift.  Ctrl+Shift+B should be able to disable the breakpoint on the current line.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b66e999e669170eb39a790a6ede48cef36a13d82

commit b66e999e669170eb39a790a6ede48cef36a13d82
Author: luoe <luoe@chromium.org>
Date: Wed Jul 12 23:37:04 2017

DevTools: align keyboard shortcut with mouse action to toggle breakpoint enabled

Cmd+B and gutter click both toggle breakpoint on a line. Gutter click + shift
also disabled the current breakpoint. This CL aligns Cmd+Shift+B to disable the
current breakpoint as well.

BUG= 741115 

Review-Url: https://codereview.chromium.org/2977753002
Cr-Commit-Position: refs/heads/master@{#486152}

[modify] https://crrev.com/b66e999e669170eb39a790a6ede48cef36a13d82/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[modify] https://crrev.com/b66e999e669170eb39a790a6ede48cef36a13d82/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
[modify] https://crrev.com/b66e999e669170eb39a790a6ede48cef36a13d82/third_party/WebKit/Source/devtools/front_end/ui/ShortcutsScreen.js

Comment 2 by l...@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment