New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741113 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Add unit tests for ChromeResourceDispatcherHostDelegate::GetPreviewsState

Project Member Reported by dougarnett@chromium.org, Jul 11 2017

Issue description

Recently server previews broke due to bug introduced in ChromeResourceDispatcherHostDelegate::GetPreviewsState

There are currently no unit tests for this method.
 

Comment 1 by bengr@chromium.org, Jul 13 2017

Components: UI>Browser>Previews
Labels: M-62
Owner: megjab...@chromium.org
Status: Assigned (was: Untriaged)
I'm assuming Megan is most familiar with this code. Megan, feel free to re-assign if I'm mistaken.
This should be somewhat easier to add since I added the unittest file for this class for something else. I think we initially skipped coverage here because there was no unit test file.

Since this method should act as a static method in a lot of ways, it should just require adding tests that call it with various combinations.
Cc: megjab...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Making available 

Comment 4 by bengr@chromium.org, Aug 15 2017

Cc: -dougarnett@chromium.org
Owner: dougarnett@chromium.org
Doug, mind taking this one?

Comment 5 by bengr@chromium.org, Dec 1 2017

Refreshed during triage.

Comment 6 by bengr@chromium.org, Dec 1 2017

Labels: -M-62 M-65

Comment 7 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 8 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
Refreshed during triage.

Comment 10 by bengr@chromium.org, Mar 21 2018

Labels: -M-65 M-68
Status: Assigned (was: Available)
Status: WontFix (was: Assigned)
The code has been refactored significantly since this was opened and refactored logic has more test coverage.

Sign in to add a comment