Intermittent choreographer assert failure in VR on L |
|||||
Issue descriptionOccasionally, some VR tests are failing due to hitting an assert related to the Choreographer. This is similar to Issue 740161 , but happens randomly instead of 100% of the time. Sample failure: C 132.083s Main ******************************************************************************** C 132.083s Main Detailed Logs C 132.083s Main ******************************************************************************** C 132.083s Main [FAIL] org.chromium.chrome.browser.vr_shell.WebVrInputTest#testPresentationLocksFocus: C 132.083s Main java.lang.AssertionError C 132.083s Main at org.chromium.chrome.browser.vr_shell.VrShellDelegate$VSyncEstimator$1.doFrame(VrShellDelegate.java:520) C 132.083s Main at android.view.Choreographer$CallbackRecord.run(Choreographer.java:765) C 132.083s Main at android.view.Choreographer.doCallbacks(Choreographer.java:580) C 132.083s Main at android.view.Choreographer.doFrame(Choreographer.java:549) C 132.083s Main at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:753) C 132.083s Main at android.os.Handler.handleCallback(Handler.java:739) C 132.083s Main at android.os.Handler.dispatchMessage(Handler.java:95) C 132.083s Main at android.os.Looper.loop(Looper.java:135) C 132.083s Main at android.app.ActivityThread.main(ActivityThread.java:5254) C 132.083s Main at java.lang.reflect.Method.invoke(Native Method) C 132.083s Main at java.lang.reflect.Method.invoke(Method.java:372) C 132.083s Main at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) C 132.083s Main at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698) This seems to only happen on Nexus 5's with L.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17fab5f8d3508e088ac3e25520fdfce7f7922fd3 commit 17fab5f8d3508e088ac3e25520fdfce7f7922fd3 Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri Jul 14 01:01:44 2017 VR: Make VSync computation more robust to slow devices. Previously we were trying to compute the actual refresh rate of the display, but this isn't possible when the VSync loop runs slow. Instead, compute the UI thread framerate, which is equivalent to the actual refresh rate on fast devices, but handles slowdowns appropriately. Bug: 741090 Change-Id: I35befba210af35f898f500ed70c8ce3b1e31a346 Reviewed-on: https://chromium-review.googlesource.com/568458 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#486569} [modify] https://crrev.com/17fab5f8d3508e088ac3e25520fdfce7f7922fd3/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Jul 14 2017
,
Mar 1 2018
,
Jul 4
,
Aug 29
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mthiesse@chromium.org
, Jul 12 2017