sysmon crashlooping |
|||||
Issue description
Traceback (most recent call last):
File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
"__main__", fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/usr/local/google/home/chromeos-test/chromiumos/chromite/scripts/sysmon/__main__.py", line 21, in <module>
from chromite.scripts.sysmon import git_metrics
File "/usr/local/google/home/chromeos-test/chromiumos/chromite/venv/chromite/scripts/sysmon/git_metrics.py", line 57, in <module>
class _GitMetricCollector(object):
File "/usr/local/google/home/chromeos-test/chromiumos/chromite/venv/chromite/scripts/sysmon/git_metrics.py", line 68, in _GitMetricCollector
description='Current Git commit hash.')
TypeError: __init__() takes at least 4 arguments (3 given)
,
Jul 11 2017
That was observed on a prod shard. chromeos-test@chromeos-server104:/var/log$ less sysmon.log
,
Jul 11 2017
,
Jul 11 2017
Those particular calls haven't be changed since March. It looks like ts_mon has changed to make those metric constructor calls invalid phobbs, are you aware of ts_mon updates?
,
Jul 11 2017
I see, the ts_mon update changed the metric constructor. I can fix sysmon, but won't this break all metrics? e.g. devserver, Autotest, others.
,
Jul 11 2017
The constructor change was supposed to be backwards incompatible. Though maybe not if certain args were positional vs. keyword. Can you make the fix for sysmon?
,
Jul 11 2017
sysmon wasn't using chromite.lib.metrics consistently.
,
Jul 12 2017
Issue 741146 has been merged into this issue.
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/a9c6e80456f59c30d0c4fa8118bb4b6387cd561f commit a9c6e80456f59c30d0c4fa8118bb4b6387cd561f Author: Allen Li <ayatane@chromium.org> Date: Wed Jul 12 03:43:40 2017 sysmon: Use chromite metrics BUG= chromium:741082 TEST=None Change-Id: I3d2ce03430cc9ff8df21ca857002b29b65f9e6df Reviewed-on: https://chromium-review.googlesource.com/567056 Reviewed-by: Aviv Keshet <akeshet@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/a9c6e80456f59c30d0c4fa8118bb4b6387cd561f/lib/metrics.py [modify] https://crrev.com/a9c6e80456f59c30d0c4fa8118bb4b6387cd561f/scripts/sysmon/git_metrics.py [modify] https://crrev.com/a9c6e80456f59c30d0c4fa8118bb4b6387cd561f/scripts/sysmon/osinfo_metrics.py [modify] https://crrev.com/a9c6e80456f59c30d0c4fa8118bb4b6387cd561f/scripts/sysmon/puppet_metrics.py [modify] https://crrev.com/a9c6e80456f59c30d0c4fa8118bb4b6387cd561f/scripts/sysmon/net_metrics.py [modify] https://crrev.com/a9c6e80456f59c30d0c4fa8118bb4b6387cd561f/scripts/sysmon/system_metrics.py [modify] https://crrev.com/a9c6e80456f59c30d0c4fa8118bb4b6387cd561f/scripts/sysmon/proc_metrics.py
,
Jul 12 2017
Traceback (most recent call last):
File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
"__main__", fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/usr/local/google/home/chromeos-test/chromiumos/chromite/scripts/sysmon/__main__.py", line 23, in <module>
from chromite.scripts.sysmon import net_metrics
File "/usr/local/google/home/chromeos-test/chromiumos/chromite/venv/chromite/scripts/sysmon/net_metrics.py", line 31, in <module>
units=metrics.MetricsDataUnits.BYTES)
AttributeError: 'module' object has no attribute 'MetricsDataUnits'
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/22989bda00998d74dab05b30edc83b5180fd12e4 commit 22989bda00998d74dab05b30edc83b5180fd12e4 Author: Allen Li <ayatane@chromium.org> Date: Wed Jul 12 22:35:35 2017 sysmon: Fix references to ts_mon units BUG= chromium:741082 TEST=None Change-Id: I9e270c294a66ce46e44747b9f5bfd29dcb0aedf8 Reviewed-on: https://chromium-review.googlesource.com/568161 Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> Commit-Queue: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/22989bda00998d74dab05b30edc83b5180fd12e4/scripts/sysmon/net_metrics.py [modify] https://crrev.com/22989bda00998d74dab05b30edc83b5180fd12e4/scripts/sysmon/system_metrics.py [modify] https://crrev.com/22989bda00998d74dab05b30edc83b5180fd12e4/scripts/sysmon/proc_metrics.py [modify] https://crrev.com/22989bda00998d74dab05b30edc83b5180fd12e4/lib/metrics.py [modify] https://crrev.com/22989bda00998d74dab05b30edc83b5180fd12e4/scripts/sysmon/puppet_metrics.py
,
Jul 13 2017
,
Jul 14 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/9949295f9f405548f467628956818612114ad317 commit 9949295f9f405548f467628956818612114ad317 Author: Aviv Keshet <akeshet@chromium.org> Date: Fri Jul 14 02:46:20 2017 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by akes...@chromium.org
, Jul 11 2017