New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741073 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Suggested apps layout, title font size/color is broken

Project Member Reported by warx@chromium.org, Jul 11 2017

Issue description

Checked out tot code today, here is the screenshot:

I will take a look, but if you have cls checked in that could be related, feel free to claim it.
 
Screenshot from 2017-07-11 13:27:15.png
740 KB View Download

Comment 1 by warx@chromium.org, Jul 11 2017

Cc: hejq@chromium.org
Looks like it is because of the flag: is_play_store_app_search_enabled_ https://cs.chromium.org/chromium/src/ui/app_list/views/search_result_tile_item_view.cc?dr=CSs&l=110

I think for start page, which has SearchResult::DISPLAY_RECOMMENDATION, the layout should not be controlled by is_play_store_app_search_enabled_ flag, instead it should be enabled/disabled just by is_fullscreen_app_list_enabled_ flag.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec6c1b3f0dbfc303a1517e0513a411e3d1068bb7

commit ec6c1b3f0dbfc303a1517e0513a411e3d1068bb7
Author: Qiang Xu <warx@chromium.org>
Date: Thu Jul 13 18:02:08 2017

app_list: use EnableFullscreenAppList for SearchResultTileItemView UI and layout

changes:
The general SearchResultTileItemView layout and UI should be controlled by
EnableFullscreenAppList flag. Those Play Store related views are enabled by
EnablePlayStoreAppSearch, like rating_, rating_star_, price_, badge_. By
checking if they are nullptr, that is equivalently checking
EnablePlayStoreAppSearch flag.

Bug:  741073 
TEST: tested without EnablePlayStoreAppSearch flag, it behaves correctly now.
Change-Id: I6ae4313698e428760fec024c487590672bda40aa
Reviewed-on: https://chromium-review.googlesource.com/567488
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486436}
[modify] https://crrev.com/ec6c1b3f0dbfc303a1517e0513a411e3d1068bb7/ui/app_list/views/search_result_tile_item_view.cc
[modify] https://crrev.com/ec6c1b3f0dbfc303a1517e0513a411e3d1068bb7/ui/app_list/views/search_result_tile_item_view.h

Comment 3 by warx@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment