[devtools] command menu shortcut opens print dialog when focus is in viewport
Reported by
kaycebas...@gmail.com,
Jul 11 2017
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3154.0 Safari/537.36 Steps to reproduce the problem: 1. Open DevTools on a Windows device. 2. Click somewhere in the viewport, so that the focus is in the viewport. 3. Press Ctrl+Shift+P. What is the expected behavior? DevTools's Command Menu opens up. What went wrong? Chrome's Print Dialog opens up. Did this work before? N/A Chrome version: 61.0.3154.0 Channel: canary OS Version: Flash Version: On Mac, Cmd+Shift+P opens the Command Menu regardless of whether focus is in the viewport or in DevTools.
,
Jul 11 2017
Ctrl-Shift-P is used in Chrome for Windows for the BASIC_PRINTING feature [1]. On Mac this basic printing hotkey is Cmd-Alt-P so it doesn't overlap with devtools. Skimming through the git blame and the related issue 374321 ... r292681 removed Ctrl+Shift+P shortcut for system dialog printing on Windows r293700 changed the condition from Windows-only to DISABLE_BASIC_PRINTING r433574 changed the condition to ENABLE_BASIC_PRINTING ...makes me suspect the original intent was lost/changed along the way. [1]: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/accelerator_table.cc?l=226&rcl=07eb249cdc03c7ca1eceda2c755def72fcbcf5f5
,
Jul 11 2017
Can we go Ctrl-Alt-P on Windows?
,
Oct 31
Bulk closing low-priority issues with no activity. Please re-file and refer to the closed issue if it's essential to fix. |
|||
►
Sign in to add a comment |
|||
Comment 1 by kayce@google.com
, Jul 11 2017