New issue
Advanced search Search tips

Issue 741054 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Cancel the timeout.

Project Member Reported by parastoog@google.com, Jul 11 2017

Issue description

UserAgent: Chrome/59.0.3071.115

The timeout is not cancelled in the destructor of the SubKeyRequest. This may cause a problem.

This could be a potential reason for this crash:

https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%3D%22payments%3A%3ASubKeyRequester%3A%3AStartRegionSubKeysRequest%22


 

Comment 1 Deleted

Owner: parastoog@chromium.org
Status: Started (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a415af7abdaf9b1f7d2b073d3f11dbe74871e13

commit 9a415af7abdaf9b1f7d2b073d3f11dbe74871e13
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Wed Jul 12 13:27:55 2017

Cancel the timeout in SubKeyRequest destructor.

This could avoid a potential crash.

Bug:  741054 
Change-Id: I7f606d0edc3741b05b73f678f7a2e28c343852f4
Reviewed-on: https://chromium-review.googlesource.com/567463
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485934}
[modify] https://crrev.com/9a415af7abdaf9b1f7d2b073d3f11dbe74871e13/components/payments/core/subkey_requester.cc

Status: Fixed (was: Started)

Sign in to add a comment