New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741051 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Display Search Results in Launcher on a large blank rectangle

Project Member Reported by newcomer@chromium.org, Jul 11 2017

Issue description

In order to prevent jank from the search results loading one at a time, load a large white rectangle and then fill it in with search results.


 
Cc: mccanny@chromium.org
Get motion spec for this new white rectangle from mccanny@
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ec16c861c09e9a138fbb6fe82c1388eaa78a719

commit 6ec16c861c09e9a138fbb6fe82c1388eaa78a719
Author: Weidong Guo <weidongg@chromium.org>
Date: Fri Jul 14 19:03:12 2017

Implement the animation of opened search box

Changes:
1. Initializes the search result page view using the same bounds, color
and background border corner raidus as the search box view to make it
hidden.

2. When there's query in the search box, grows the search result page in
the same pace as the search box to make them look like a single growing
view.

Screenshots of animation:
https://screenshot.googleplex.com/FNsJ0bE9s29
https://screenshot.googleplex.com/4ObTEsitpRK
https://screenshot.googleplex.com/sHQWVWaqavH
https://screenshot.googleplex.com/HVFKUXrYQhO

Specs: https://screenshot.googleplex.com/409fBM7pTO2

BUG= 741051 

Change-Id: I2fc15631e6675169dcb0ab222ce1af4cdc9cf2d2
Reviewed-on: https://chromium-review.googlesource.com/570835
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486825}
[modify] https://crrev.com/6ec16c861c09e9a138fbb6fe82c1388eaa78a719/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/6ec16c861c09e9a138fbb6fe82c1388eaa78a719/ui/app_list/app_list_constants.h
[modify] https://crrev.com/6ec16c861c09e9a138fbb6fe82c1388eaa78a719/ui/app_list/views/app_list_page.h
[modify] https://crrev.com/6ec16c861c09e9a138fbb6fe82c1388eaa78a719/ui/app_list/views/contents_view.cc
[modify] https://crrev.com/6ec16c861c09e9a138fbb6fe82c1388eaa78a719/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/6ec16c861c09e9a138fbb6fe82c1388eaa78a719/ui/app_list/views/search_box_view.h
[modify] https://crrev.com/6ec16c861c09e9a138fbb6fe82c1388eaa78a719/ui/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/6ec16c861c09e9a138fbb6fe82c1388eaa78a719/ui/app_list/views/search_result_view.cc

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment