New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 741046 link

Starred by 2 users
Status: Duplicate
Merged: issue 177475
Owner: ----
Closed: Jan 2018
Cc:
█ danzh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

use FALLTHROUGH annotation in switch block

Project Member Reported by danzh@chromium.org, Jul 11 2017 
We use implicit fallthrough in switch block, e.g. https://cs.chromium.org/chromium/src/net/quic/core/quic_framer.cc?rcl=0e72ffcbe71a6c4604735dff8ed284154d89eb9b&l=361. It'll be good if we have clang::fallthrough to mark the fallthrough as intended at those places.

We can add something similar to https://cs.chromium.org/chromium/src/third_party/webrtc/typedefs.h?rcl=a5b6c5225f63063a54130acc8da4c808c648e360&l=96
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63e03761b26c443cddcfe0883e3fa127871bc4d6

commit 63e03761b26c443cddcfe0883e3fa127871bc4d6
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jan 26 17:55:14 2018

Make //net:net build with -Wimplicit-fallthrough.

Looks like all fallthroughs in net were intentional.
No intended behavior change.

Bug:  741046 , 177475 
Change-Id: I004ce3a7b2eb487a34972ced44e1b564468c7d70
Reviewed-on: https://chromium-review.googlesource.com/887303
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531994}
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/base/net_errors.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/base/network_throttle_manager_impl.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/cert/cert_status_flags.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/disk_cache/blockfile/histogram_macros.h
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/dns/dns_config_service_posix.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/dns/dns_hosts.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/filter/gzip_header.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/http2/decoder/payload_decoders/altsvc_payload_decoder.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/http2/decoder/payload_decoders/data_payload_decoder.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/http2/decoder/payload_decoders/goaway_payload_decoder.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/http2/decoder/payload_decoders/headers_payload_decoder.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/http2/decoder/payload_decoders/push_promise_payload_decoder.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/http2/hpack/decoder/hpack_entry_decoder.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/http2/hpack/decoder/hpack_string_decoder.h
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/quic/chromium/crypto/proof_verifier_chromium.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/quic/core/congestion_control/bbr_sender.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/quic/core/congestion_control/send_algorithm_interface.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/quic/core/crypto/crypto_framer.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/quic/core/crypto/quic_crypto_server_config.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/quic/core/quic_spdy_session.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/quic/http/decoder/payload_decoders/quic_http_altsvc_payload_decoder.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/quic/http/decoder/payload_decoders/quic_http_data_payload_decoder.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/quic/http/decoder/payload_decoders/quic_http_goaway_payload_decoder.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/quic/http/decoder/payload_decoders/quic_http_headers_payload_decoder.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/quic/http/decoder/payload_decoders/quic_http_push_promise_payload_decoder.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/socket/ssl_client_socket_pool.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/socket/ssl_server_socket_impl.cc
[modify] https://crrev.com/63e03761b26c443cddcfe0883e3fa127871bc4d6/net/spdy/core/spdy_framer.cc

Comment 2 by thakis@chromium.org, Jan 30 2018

Mergedinto: 177475
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment