CQ Dry run should probably skip sign cla check OR better just warn but not abort attempt |
|||||
Issue descriptionSee: https://chromium-review.googlesource.com/c/566340/5 The CL is owned by somebody without try access. I'm committer and triggered a dry run in https://chromium-review.googlesource.com/c/566340/5#message-3953c078222e7e6af1d3304ef0972202e2ddfef6 CQ started, but again complained that there's no access in the following comment.
,
Jul 11 2017
tl;dr agree that DRY RUN should probably skip checking if author signed CLA, or otherwise just warn but not fail. Analyzing CQ triggering: 1. author CQ+2 on https://chromium-review.googlesource.com/c/566340/5#message-1af4e77c3253df30d76067213733b3dbced143e1 => only full committers or CL owner with tryjob access are allowed to trigger CQ. WAI. 2. machenbach@ (committer-reviewer) CQ+1 => The author wangqing-hf@loongson.cn has not signed Google Contributor License Agreement. https://chromium-review.googlesource.com/c/566340/5#message-67320e8135a7e6238e78f6667176f996f65d6d6e maybe not WAI, but 3. author Commit-Queue+1 https://chromium-review.googlesource.com/c/566340/5#message-d6c9002f75710870361c1f60aa843443a3caf4ca => Dry run: only full committers or CL owner with tryjob access are allowed to trigger CQ dry run WAI.
,
Jul 12 2017
Everything was alright after the CLA was signed. So here we should first establish if it's important to change anything at all. A future contributor is required to sign anyways, so why not do so before dry running... One thing that could have been slightly helpful, could have been a warning already when the owner tried to run CQ. There the CLA check could have been performed already and give him more warnings.
,
Jul 20 2017
https://chrome-internal-review.googlesource.com/c/415068
,
Jul 20 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/1272345c340bbd8a855af5f4be0464f6d09cedf4 commit 1272345c340bbd8a855af5f4be0464f6d09cedf4 Author: Aaron Gable <agable@chromium.org> Date: Thu Jul 20 22:23:23 2017
,
Jul 20 2017
,
Jul 21 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/0126158e8b9df37f4557bab03d9b0bbd8b612258 commit 0126158e8b9df37f4557bab03d9b0bbd8b612258 Author: Aaron Gable <agable@chromium.org> Date: Fri Jul 21 18:09:41 2017 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by machenb...@chromium.org
, Jul 11 2017