Issue metadata
Sign in to add a comment
|
VR: Prevent mouse move events while clicking to make link clicking more robust. |
||||||||||||||||||||||||||
Issue descriptionThis was fixed in CL 2944453002 but regressed. Likely due to CL 558387.
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43beffafd4870a21f4a6f1a06a76307e22b639a9 commit 43beffafd4870a21f4a6f1a06a76307e22b639a9 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Wed Jul 12 15:23:34 2017 [vr] Prevent mouse move events while clicking. - Relands fix of https://codereview.chromium.org/2944453002. Bug: 741020 Change-Id: Id6cb772edd0509afa60c217be02188bf16fcada9 Reviewed-on: https://chromium-review.googlesource.com/567384 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#485956} [modify] https://crrev.com/43beffafd4870a21f4a6f1a06a76307e22b639a9/chrome/browser/android/vr_shell/vr_shell_gl.cc
,
Jul 12 2017
,
Jul 14 2017
Issue 742633 has been merged into this issue.
,
Jul 14 2017
Something still seems off in 61.0.3156.4. It seems a little better, but I'm having the following issues on badssl.com: (1) In normal Clank, I can tap anywhere within one of the rows to navigate to a link. In VR mode, it seems like tapping inside the box (but not on the text) gets the link stuck in a hover state, and doesn't navigate. (2) It's still sometimes hard to click on links. It doesn't happen always, but sometimes I try to click on a link (on the text itself) and have to click several times to get it to navigate. (I have similar problems on www.google.com so I don't the website is doing anything funny.)
,
Jul 15 2017
I saw this as well on the same revision. It looks like it's at commit position 486205, which should include tiborg@'s change at 485956.
,
Jul 17 2017
,
Jul 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac18515dcf32d484430bc1c7f2b35e60152b4ca0 commit ac18515dcf32d484430bc1c7f2b35e60152b4ca0 Author: Ian Vollick <vollick@chromium.org> Date: Mon Jul 17 16:20:32 2017 [vr] Apply content move suppression in UiInputManager The change in https://chromium-review.googlesource.com/567384 did not have exactly the same behaviour as the change in https://codereview.chromium.org/2944453002. This CL moves the content move suppression as per the previous CL and introduces a testing framework for the UiInputManager. Bug: 741020 , 743014 Change-Id: Idd8fb0a1c6fb3f74c24dc555b1a72e0c7c3bc611 Reviewed-on: https://chromium-review.googlesource.com/573100 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#487104} [modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/android/vr_shell/vr_shell_gl.h [modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/BUILD.gn [add] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/test/mock_browser_interface.cc [add] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/test/mock_browser_interface.h [add] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/test/ui_scene_manager_test.cc [add] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/test/ui_scene_manager_test.h [modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/ui_input_manager.cc [modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/ui_input_manager.h [add] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/ui_input_manager_unittest.cc [modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/ui_renderer.cc [modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/ui_scene_manager_unittest.cc
,
Jul 17 2017
,
Jul 20 2017
Issue 746453 has been merged into this issue.
,
Sep 26 2017
Verified in 63.0.3223.7 |
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by tiborg@chromium.org
, Jul 11 2017