New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741009 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

all apps indicator on non-first page

Project Member Reported by warx@chromium.org, Jul 11 2017

Issue description

all apps indicator on the first page will move up when scrolling up, but it should also show on the second page.

Discuss the right behavior with UX and implement it.
 

Comment 1 by maajid@chromium.org, Jul 11 2017

This seems to be a duplicate of https://bugs.chromium.org/p/chromium/issues/detail?id=739918, can you clarify/merge them? Thanks!

Comment 2 by warx@chromium.org, Jul 11 2017

This is not the dup. Indicator has "ALL APPS" label. They are different things : )

Comment 3 by warx@chromium.org, Jul 11 2017

Btw, the description is described after https://chromium-review.googlesource.com/c/564485/ is landed, so it is a bit of confusing right now.

Comment 4 by maajid@chromium.org, Jul 11 2017

Clarified with offline discussion; this tracks the ALL APPS label missing after the suggested apps section is added to the full screen app list view per https://chromium-review.googlesource.com/c/564485/ 


Comment 5 by warx@chromium.org, Jul 12 2017

Discussed with UX, the wanted behavior is when scrolling up, all apps indicator will replace suggested apps indicator, and stop there, then all apps tiles scrolling underneath the all apps indicator.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a4dc1da3f469b22578fd96b5a1a2169d081d663

commit 2a4dc1da3f469b22578fd96b5a1a2169d081d663
Author: Qiang Xu <warx@chromium.org>
Date: Thu Jul 13 02:33:21 2017

app_list: set all apps indicator negative transition offset limit

changes:
Set all apps indicator negative transition offset limit to the place of
initial suggested apps indicator.
This will make:
(1) when scrolling up, all apps indicator will stop at 21px padding
away from search box, while all apps tiles scrolling underneath it.
(2) all apps indicator will be shown on non-first page due to (1).

Bug:  741009 
TEST: tested with fullscreen app list enabled
Change-Id: I7fa71f041f81b0939c507fb246589cfdb6dbc06a
Reviewed-on: https://chromium-review.googlesource.com/569378
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486230}
[modify] https://crrev.com/2a4dc1da3f469b22578fd96b5a1a2169d081d663/ui/app_list/views/apps_grid_view.cc

Comment 7 by warx@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment