New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741008 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

all apps scrolling fade-out zone

Project Member Reported by warx@chromium.org, Jul 11 2017

Issue description

all apps should have two gradient fade-out zone: 21px height, 100% opacity down to 0% opacity up

 

Comment 1 by warx@chromium.org, Jul 11 2017

Components: UI>Shell>Launcher

Comment 2 by warx@chromium.org, Jul 11 2017

Labels: NewLauncherUIV1
Duplicate bug 740799

Comment 4 by warx@chromium.org, Jul 11 2017

Mergedinto: 740799
Status: Duplicate (was: Assigned)
Thanks!

Comment 5 by warx@chromium.org, Jul 11 2017

Status: Assigned (was: Duplicate)
Summary: all apps scrolling fade-out zone (was: all apps fade-out zone)
Discussed with min, alex offline, dedup for now.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2630b8cd26e2afb5caa9692cf024273b5e72d537

commit 2630b8cd26e2afb5caa9692cf024273b5e72d537
Author: Qiang Xu <warx@chromium.org>
Date: Wed Jul 26 22:45:26 2017

app_list: implement fade-out zones for all apps

changes:
(1) Make default contents size height fixed at 633px.
(2) Make suggestions container and indicator views paint to layer.
(3) Create and apply a mask layer, which has top and bottom 21px height
opacity gradient zones.

specs: https://screenshot.googleplex.com/hh1pbCRYHnV

TEST: tested with --enable-features=EnableFullscreenAppList flag
Bug:  741008 
Change-Id: Ieb882bbf04f9707e44e3999f6ba3f456e17a5eb0
Reviewed-on: https://chromium-review.googlesource.com/578496
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489783}
[modify] https://crrev.com/2630b8cd26e2afb5caa9692cf024273b5e72d537/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/2630b8cd26e2afb5caa9692cf024273b5e72d537/ui/app_list/views/apps_grid_view.h
[modify] https://crrev.com/2630b8cd26e2afb5caa9692cf024273b5e72d537/ui/app_list/views/contents_view.cc

Comment 7 by warx@chromium.org, Jul 27 2017

Labels: M-61 Merge-Request-61
launcher cl for m61

Comment 8 by ketakid@google.com, Jul 27 2017

Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 31 2017

Cc: ketakid@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a56957a2389025cadf77eb9b980c6c6e29c264e5

commit a56957a2389025cadf77eb9b980c6c6e29c264e5
Author: Maajid <maajid@chromium.org>
Date: Mon Jul 31 21:25:30 2017

app_list: implement fade-out zones for all apps

changes:
(1) Make default contents size height fixed at 633px.
(2) Make suggestions container and indicator views paint to layer.
(3) Create and apply a mask layer, which has top and bottom 21px height
opacity gradient zones.

specs: https://screenshot.googleplex.com/hh1pbCRYHnV

TBR=warx@chromium.org

(cherry picked from commit 2630b8cd26e2afb5caa9692cf024273b5e72d537)

TEST: tested with --enable-features=EnableFullscreenAppList flag
Bug:  741008 
Change-Id: Ieb882bbf04f9707e44e3999f6ba3f456e17a5eb0
Reviewed-on: https://chromium-review.googlesource.com/578496
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489783}
Reviewed-on: https://chromium-review.googlesource.com/594889
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#185}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/a56957a2389025cadf77eb9b980c6c6e29c264e5/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/a56957a2389025cadf77eb9b980c6c6e29c264e5/ui/app_list/views/apps_grid_view.h
[modify] https://crrev.com/a56957a2389025cadf77eb9b980c6c6e29c264e5/ui/app_list/views/contents_view.cc

Comment 11 by warx@chromium.org, Aug 1 2017

Status: Fixed (was: Assigned)

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment