WebStatePolicyDecider::ShouldAllowRequest and DidStartNavigation called in different order |
||
Issue descriptionFor renderer-initiated navigations ShouldAllowRequest is called before DidStartNavigation For user-initiated navigations DidStartNavigation is called before ShouldAllowRequest The order should be deterministic and ShouldAllowRequest should be always called first.
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f3191e467defe10f4655b6143ef320c3de77a71 commit 5f3191e467defe10f4655b6143ef320c3de77a71 Author: Eugene But <eugenebut@google.com> Date: Fri Sep 15 22:21:35 2017 Updated NavigationCallbacksTest to verify callbacks order. The order verification will be used later to test the order of WebStatePolicyDecider and DidStartNavigation callbacks. Bug: 741006 Change-Id: I1bea40e42d6c1d129e80b80a9a771e7a21daa6ae Reviewed-on: https://chromium-review.googlesource.com/669746 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#502404} [modify] https://crrev.com/5f3191e467defe10f4655b6143ef320c3de77a71/ios/web/web_state/navigation_callbacks_inttest.mm
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a3bceca0d12ba1ad4b2da10d432c990cc6f73db commit 8a3bceca0d12ba1ad4b2da10d432c990cc6f73db Author: Eugene But <eugenebut@google.com> Date: Wed Sep 20 15:14:43 2017 Test the order of ShouldAllowRequest/Response callbacks. CL does not have any functional changes, and only adds tests for WebStatePolicyDecider/WebStateObserver callbacks order. The order is not consistent ( crbug.com/741006 ) and will be fixed in a separate CL. Bug: 741006 Change-Id: Ib362bddf00261ade0552bb6da42ba64fe608d9c9 Reviewed-on: https://chromium-review.googlesource.com/673049 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#503145} [modify] https://crrev.com/8a3bceca0d12ba1ad4b2da10d432c990cc6f73db/ios/web/web_state/navigation_callbacks_inttest.mm
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b30649507a75cc3e50674ee6645c8545c272fec commit 2b30649507a75cc3e50674ee6645c8545c272fec Author: Eugene But <eugenebut@google.com> Date: Fri Sep 22 18:33:19 2017 Always call DidStartNavigation after ShouldAllowRequest. Call ShouldAllowRequest when navigation has actually started, not when load request was registered. Bug: 741006 Change-Id: I70d8621d5107cdb25de60d26d2008332d709d85e Reviewed-on: https://chromium-review.googlesource.com/676243 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#503804} [modify] https://crrev.com/2b30649507a75cc3e50674ee6645c8545c272fec/ios/web/public/web_state/web_state_policy_decider.h [modify] https://crrev.com/2b30649507a75cc3e50674ee6645c8545c272fec/ios/web/web_state/navigation_callbacks_inttest.mm [modify] https://crrev.com/2b30649507a75cc3e50674ee6645c8545c272fec/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/2b30649507a75cc3e50674ee6645c8545c272fec/ios/web/webui/crw_web_ui_manager.h [modify] https://crrev.com/2b30649507a75cc3e50674ee6645c8545c272fec/ios/web/webui/crw_web_ui_manager.mm [modify] https://crrev.com/2b30649507a75cc3e50674ee6645c8545c272fec/ios/web/webui/crw_web_ui_manager_unittest.mm
,
Sep 22 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by eugene...@chromium.org
, Jul 12 2017Status: Assigned (was: Available)