New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740999 link

Starred by 3 users
Status: Assigned
Owner:
█ helenepark@chromium.org
Last visit > 30 days ago
Cc:
est...@chromium.org
█ rpop@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Motion in tab title during loading

Project Member Reported by est...@chromium.org, Jul 11 2017 
We'd like to smooth out the appearance of the tab as a page loads content. Questions:

- what is the ui review status?
- Is there a specification for the timing/tween of the slide?
- I notice there's also a cross fade between "New Tab" and "Actual Website Name". When should this occur?
 * during all title changes
 * only if the domain has changed
 * only from "New Tab" to XXX
 * other

see related  issue 734104  which is more about minimizing the number of times we change UI during loading.

Comment 1 by est...@chromium.org, Jul 17 2017 

I have a patch here for sliding the title: https://chromium-review.googlesource.com/c/571851/

ping on the above questions. Regarding the ui review status --- is this something we need to add behind a flag or can we just make the change unconditionally?

Comment 2 by bettes@chromium.org, Aug 14 2017 

I don't see a need for a flag – maybe we can get a screen capture of what your patch does?

Comment 3 by est...@chromium.org, Aug 17 2017 

here's a screencast
Aug 17 2017 2_27 PM.webm
1.4 MB View Download

Comment 4 by helenepark@chromium.org, Aug 21 2017 

Thank you for the screencast, looking good.
would it be possible to add an 80% in, 40% out motion curve to the text moving to the right?
Screen Shot 2017-08-21 at 10.40.51 AM.png
20.1 KB View Download

Comment 5 by est...@chromium.org, Aug 21 2017 

yes, that would be easy to do (note to self: FAST_OUT_SLOW_IN). What about the text sliding to the left?

Comment 6 by est...@chromium.org, Aug 23 2017

AwesomeScreenshot-2017-08-23T16-52-54-818Z.webm
1.7 MB View Download

Comment 7 by helenepark@chromium.org, Aug 28 2017 

LGTM, thanks!
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4d6510204bf83d96f7bbcd40ecdbe919ec6d61b

commit a4d6510204bf83d96f7bbcd40ecdbe919ec6d61b
Author: Evan Stade <estade@chromium.org>
Date: Wed Aug 30 16:28:34 2017

Views: Slide tab title during load.

Bug: 740999
Change-Id: I7aa00f7ec3e0bd4dad9dba9dc4e25e8c63dacf25
Reviewed-on: https://chromium-review.googlesource.com/571851
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498490}
[modify] https://crrev.com/a4d6510204bf83d96f7bbcd40ecdbe919ec6d61b/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/a4d6510204bf83d96f7bbcd40ecdbe919ec6d61b/chrome/browser/ui/views/tabs/tab.h

Comment 9 by sky@chromium.org, Sep 7 2017

Cc: est...@chromium.org
FWIW I find the tab slide animation visually distracting. It really draws my attention where as previously that wasn't the case. I notice it more on chromeos. I have a config that starts up with one window that has three tabs: two google and one ntp. In this config I get the animation on each tab twice. Once for the load, and then back because we don't show the favicon on these tabs.

Comment 10 by rpop@chromium.org, Sep 7 2017 

Is this in canary by default? I can't get it to trigger.

Comment 11 by rpop@chromium.org, Sep 7 2017 

Nevermind, I see it on new tabs. But not on the NTP as #9 is saying.

Comment 12 by helenepark@chromium.org, Oct 17 2017 

how do you get it trigger? is this behind a flag?

Comment 13 by est...@chromium.org, Oct 17 2017 

no flag is needed on windows/chrome os/linux. Mac is not implemented.
►

Sign in to add a comment