New issue
Advanced search Search tips

Issue 740997 link

Starred by 2 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Jul 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Port.test_type returns "unknown" for many tests with knowable types.

Project Member Reported by qyears...@chromium.org, Jul 11 2017 
For example:

$ ./print-layout-test-types external/wpt/2dcontext/fill-and-stroke-styles/2d.strokeStyle.default.html

prints "unknown", although the test contains "testharness.js" and is listed in MANIFEST.json as a testharness test.

Currently test_type is determined only by what type of baselines exist in the file system, but instead it could be determined the same way it's determined when running the tests.
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 12

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by foolip@chromium.org, Jul 18

Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)
The script has been renamed, but `third_party/blink/tools/print_web_test_types.py external/wpt/2dcontext/fill-and-stroke-styles/2d.strokeStyle.default.html` does still say "unknown".

qyearsley@, assigning to you for extra details. I can't find this script used anywhere, nor the internal print_layout_test_types in blinkpy. Can we just remove the script?

Comment 3 by qyearsley@google.com, Jul 18

Status: Started (was: Assigned)
I believe we can just remove it.

Uploaded https://chromium-review.googlesource.com/c/chromium/src/+/1142229.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40dc5cb91ad0286abc06dbb213067da6445044ff

commit 40dc5cb91ad0286abc06dbb213067da6445044ff
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Jul 19 01:21:07 2018

[blinkpy] Remove Port.test_type and print_web_test_types.py

Port.test_type just tries to guess about test type based on
baselines; it sometimes returns "unknown" for test types that
actually are knowable (e.g. because they're in wpt manifest).

This method isn't used except in the script print_web_test_types.py,
and I believe nobody is using that script.

Bug:  740997 
Change-Id: I1e98601504affd2d75ab92409ae20da9d28b92a4
Reviewed-on: https://chromium-review.googlesource.com/1142229
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576299}
[modify] https://crrev.com/40dc5cb91ad0286abc06dbb213067da6445044ff/third_party/blink/tools/blinkpy/web_tests/port/base.py
[delete] https://crrev.com/15272e4210056c25b91fccca353ff0be47522eaf/third_party/blink/tools/blinkpy/web_tests/print_layout_test_types.py
[delete] https://crrev.com/15272e4210056c25b91fccca353ff0be47522eaf/third_party/blink/tools/blinkpy/web_tests/print_layout_test_types_unittest.py
[delete] https://crrev.com/15272e4210056c25b91fccca353ff0be47522eaf/third_party/blink/tools/print_web_test_types.py

Comment 5 by qyears...@chromium.org, Jul 19

Status: Fixed (was: Started)
►

Sign in to add a comment