Add support for ignored variations params to FeatureEngagementTracker |
|||
Issue descriptionChrome Version: M61+, 0236f57d048f08e29ddf2c6e0f8b2cb6f11695ab OS: All What steps will reproduce the problem? (1) Add an extra param not listed in the documentation to your In-Product Help configuration, using the prefix "x_" - See https://chromium.googlesource.com/chromium/src/+/master/components/feature_engagement_tracker/README.md#Using-Chrome-Variations (2) Let the client parse the configuration. What is the expected result? Nothing happens when the feature engagement tracker parses the data. What happens instead? This histogram InProductHelp.Config.ParsingEvent gets this value incremented: FAILURE_UNKNOWN_KEY The reason is that the code does not yet support any ignored prefix.
,
Jul 11 2017
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2191be481e59b5019a321e623399973cbdfc726d commit 2191be481e59b5019a321e623399973cbdfc726d Author: Tommy Nyquist <nyquist@chromium.org> Date: Tue Jul 11 23:48:56 2017 Add support for ignored variations params to FeatureEngagementTracker The FeatureEngagementTracker currently records a histogram event for InProductHelp.Config.ParsingEvent: FAILURE_UNKNOWN_KEY whenever an unknown key is found in the Chrome Variations parameters. However sometimes developers might want to intentionally add more configurable values related to the In-Product Help experiment such as choosing strings for their promo. Before this CL, that would always record an additional entry in the histogram mentioned above. Since the histogram is meant to identify incorrect server side configurations, it is not helpful that it is triggered if the parameter is there intentionally. This CL therefore adds support for specifying additional parameters that are fully ignored by using a special prefix: "x_". Any param that starts with that is fully ignored, such as: "x_promo_string". The tests are updated to ensure that the histogram counts behave as expected. BUG= 740994 Change-Id: I8ba548b86855d2d1028e7ba7ef8c67c9038ae2dc Reviewed-on: https://chromium-review.googlesource.com/567320 Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#485729} [modify] https://crrev.com/2191be481e59b5019a321e623399973cbdfc726d/components/feature_engagement_tracker/README.md [modify] https://crrev.com/2191be481e59b5019a321e623399973cbdfc726d/components/feature_engagement_tracker/internal/chrome_variations_configuration.cc [modify] https://crrev.com/2191be481e59b5019a321e623399973cbdfc726d/components/feature_engagement_tracker/internal/chrome_variations_configuration_unittest.cc
,
Jul 12 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nyquist@chromium.org
, Jul 11 2017