New issue
Advanced search Search tips

Issue 740987 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-02-01
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Remove Javascript POST workaround

Project Member Reported by michaeldo@chromium.org, Jul 11 2017

Issue description

The workaround to send POST requests through Javascript instead of directly with WKWebView can be removed once support for iOS 10 is dropped. (As this was introduced in iOS 11.)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 2017

Cc: eugene...@chromium.org
NextAction: 2018-12-01
Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 12

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Components: Mobile>iOSWeb
Components: -Mobile>WebView>Glue
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58a6b4910cafd88be5a971e6cbd5e10171f91524

commit 58a6b4910cafd88be5a971e6cbd5e10171f91524
Author: Justin Cohen <justincohen@google.com>
Date: Wed Nov 14 19:27:19 2018

[ios] Drop iOS10 specific code.

875528, 875528, 750185, 850814

Bug: 894099,  766951 ,  836808 , 740987,  765146 ,  826369 ,  730461 ,  869176 ,
Change-Id: I07b3ab43cff3d4d4f17349fe5eff9070fef5d437
Reviewed-on: https://chromium-review.googlesource.com/c/1335207
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608075}
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/autofill/autofill_controller_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/autofill/form_input_accessory_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/drag_and_drop/drop_and_navigate_interaction_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/metrics/drag_and_drop_recorder.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/net/cookie_util.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/net/cookie_util_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/prerender/prerender_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/snapshots/snapshot_tab_helper.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/app_launcher/open_mail_handler_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_option_button.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_personalization_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_cell.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_presentation_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/bubble/bubble_view_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/find_bar/find_bar_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/fullscreen/fullscreen_system_notification_observer.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/history/history_table_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/history/history_ui_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/infobars/confirm_infobar_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/main_content/web_scroll_view_main_content_ui_forwarder.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/ntp/incognito_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/payments/cells/page_info_item.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/payments/cells/payments_selector_edit_item.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/print/print_controller_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/tab_grid_transition_handler.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/table_view/table_view_presentation_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tabs/tab_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/adaptive_toolbar_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/primary_toolbar_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/secondary_toolbar_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar_container/toolbar_container_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar_container/toolbar_container_view_controller_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/util/uikit_ui_util.h
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/util/uikit_ui_util.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/web/cache_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/common/ui_util/BUILD.gn
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/common/ui_util/constraints_ui_util.h
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/common/ui_util/constraints_ui_util.mm
[delete] https://crrev.com/d8af30684b21a6141ab4b4e163eb300f6cb1c4af/ios/chrome/common/ui_util/constraints_ui_util_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/showcase/payments/sc_payments_picker_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/showcase/test/showcase_eg_utils.mm

Status: WontFix (was: Available)
WontFix now that iOS10 is dropped.
Cc: justincohen@chromium.org
Status: Available (was: WontFix)
This bug is about removing the code and the code is still there. Justin, I'm I missing something?
Woops, we removed a reference to this in ios/chrome, but it's still in ios/web (as expected since it supports iOS10).

Thanks for catching this, sorry for incorrectly closing.
The NextAction date has arrived: 2018-12-01
NextAction: 2019-02-01
ios/web still supports iOS10

Sign in to add a comment