[WPT Import] Importer fails to submit after successful CQ run (Gerrit says needs review) |
||
Issue descriptionIn this import: https://chromium-review.googlesource.com/c/566218/ The CL has "TBR: qyearsley@chromium.org", but after passing CQ dry run and setting to Code-Review +2 (via git cl set-commit), the CL got a comment by Commit Bot saying: > CL must be approved before triggering CQ
,
Jul 13 2017
It happened here too: https://chromium-review.googlesource.com/c/568810/
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/844a10b4452de0948aefcee33e90e209564c437e commit 844a10b4452de0948aefcee33e90e209564c437e Author: Quinten Yearsley <qyearsley@google.com> Date: Thu Jul 13 21:51:56 2017 In wpt importer on upload also pass --tbr. Bug: 740986 Change-Id: I0b478cb89853994d444e9a17796aa06c6a36a430 Reviewed-on: https://chromium-review.googlesource.com/570676 Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#486484} [modify] https://crrev.com/844a10b4452de0948aefcee33e90e209564c437e/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py [modify] https://crrev.com/844a10b4452de0948aefcee33e90e209564c437e/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
,
Jul 14 2017
I believe this should be fixed now, will confirm on next auto-import. |
||
►
Sign in to add a comment |
||
Comment 1 by qyears...@chromium.org
, Jul 11 2017