New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740981 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

cros component - starcupsdrv

Project Member Reported by xiaochu@chromium.org, Jul 11 2017

Issue description

On both server, client side.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2d768c4c559fe267fe0c96b5d8b26d489256c0ce

commit 2d768c4c559fe267fe0c96b5d8b26d489256c0ce
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Sun Aug 06 05:07:55 2017

net-print/cups: search filter for star printer

Allow cupsd search for filter in /run/imageloader/star-cups-driver.

BUG= chromium:740981 
TEST=cupstestppd on DUT.

Change-Id: Iac216a827b0b5afde0eeafe9a246e7d5ba2de77a
Reviewed-on: https://chromium-review.googlesource.com/601056
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[rename] https://crrev.com/2d768c4c559fe267fe0c96b5d8b26d489256c0ce/net-print/cups/cups-2.1.4-r23.ebuild
[modify] https://crrev.com/2d768c4c559fe267fe0c96b5d8b26d489256c0ce/net-print/cups/files/cups-2.1.4-search-filter.patch

Comment 2 by skau@chromium.org, Aug 8 2017

Cc: skau@chromium.org
Components: Internals>Printing>CUPS
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36353d73147aa8ee4f8da90f2cb779d3aaca5bdc

commit 36353d73147aa8ee4f8da90f2cb779d3aaca5bdc
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Wed Aug 09 18:42:05 2017

Add entries in filter->component mapping

    rastertostarlm/rastertostar are binary filters delivered by
    star-cups-driver component.
    
    epson-escpr-wrapper and epson-escpr are binary filters deliverd by
    epson-inkjet-printer-escpr component.
    
    For small amount of ppds we have seen, epson-escpr-wrapper and
    rastertostarlm are what being used. But there is no specific reason to
    disallow the use of the other two binaries.

BUG= chromium:740981 
TEST=manual

Change-Id: Iba88e6af1e3ecc2b1d656bb3a2090653fa49dfc1
Reviewed-on: https://chromium-review.googlesource.com/606489
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493074}
[modify] https://crrev.com/36353d73147aa8ee4f8da90f2cb779d3aaca5bdc/chrome/browser/chromeos/printing/printer_configurer.cc

Cc: keta...@chromium.org adlr@chromium.org
Labels: -Pri-3 Merge-Request-61 Pri-1
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 16 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Summary: cros component - starcupsdrv (was: 2nd chrome os component - starcupsdrv)
Please tag with appropriate OSs.

Comment 9 by adlr@chromium.org, Aug 17 2017

Labels: OS-Chrome
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 and M62.
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 11 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
What is the branch name I'm merging into?
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 11 2017

Labels: merge-merged-release-R61-9765.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/779bfeb88b3eda4de4040a2c9d6152ee22481007

commit 779bfeb88b3eda4de4040a2c9d6152ee22481007
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Mon Sep 11 18:12:29 2017

net-print/cups: search filter for star printer

Allow cupsd search for filter in /run/imageloader/star-cups-driver.

BUG= chromium:740981 
TEST=cupstestppd on DUT.

Change-Id: Iac216a827b0b5afde0eeafe9a246e7d5ba2de77a
Reviewed-on: https://chromium-review.googlesource.com/601056
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
(cherry picked from commit 2d768c4c559fe267fe0c96b5d8b26d489256c0ce)
Reviewed-on: https://chromium-review.googlesource.com/660979
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>

[rename] https://crrev.com/779bfeb88b3eda4de4040a2c9d6152ee22481007/net-print/cups/cups-2.1.4-r23.ebuild
[modify] https://crrev.com/779bfeb88b3eda4de4040a2c9d6152ee22481007/net-print/cups/files/cups-2.1.4-search-filter.patch

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 12 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78664dde40a0032c4e1aa8712e07cc9e15915768

commit 78664dde40a0032c4e1aa8712e07cc9e15915768
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Tue Sep 12 20:11:36 2017

[merge to 61]Add entries in filter->component mapping

    rastertostarlm/rastertostar are binary filters delivered by
    star-cups-driver component.
    
    epson-escpr-wrapper and epson-escpr are binary filters deliverd by
    epson-inkjet-printer-escpr component.
    
    For small amount of ppds we have seen, epson-escpr-wrapper and
    rastertostarlm are what being used. But there is no specific reason to
    disallow the use of the other two binaries.

BUG= chromium:740981 
TEST=manual

Change-Id: Iba88e6af1e3ecc2b1d656bb3a2090653fa49dfc1
Reviewed-on: https://chromium-review.googlesource.com/606489
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493074}(cherry picked from commit 36353d73147aa8ee4f8da90f2cb779d3aaca5bdc)
Reviewed-on: https://chromium-review.googlesource.com/661053
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1173}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/78664dde40a0032c4e1aa8712e07cc9e15915768/chrome/browser/chromeos/printing/printer_configurer.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bee1447034287146e8ef793e84cb84cd91894ae

commit 1bee1447034287146e8ef793e84cb84cd91894ae
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Tue Sep 12 22:50:32 2017

[merge to 61]Add entry for star-cups-driver in component table.

BUG= chromium:740981 
TEST=None

Change-Id: Ia0a1a00cf8a350b540fb49410a7893a1c4c33c57
Reviewed-on: https://chromium-review.googlesource.com/601165
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492801}(cherry picked from commit 5ea4fc83ffccd71622e55fea4e56ddc17dd03fc9)
Reviewed-on: https://chromium-review.googlesource.com/660879
Cr-Commit-Position: refs/branch-heads/3163@{#1179}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/1bee1447034287146e8ef793e84cb84cd91894ae/chrome/browser/component_updater/cros_component_installer.cc
[modify] https://crrev.com/1bee1447034287146e8ef793e84cb84cd91894ae/chrome/browser/component_updater/cros_component_installer.h
[modify] https://crrev.com/1bee1447034287146e8ef793e84cb84cd91894ae/chrome/browser/component_updater/cros_component_installer_unittest.cc

Status: Fixed (was: Started)
skau@ helped merge all 3 CLs. Thanks!

Comment 18 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 19 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment