New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740980 link

Starred by 1 user
Status: Fixed
Owner:
sdefresne@chromium.org
Closed: Jul 2017
Cc:
mbonadei@chromium.org
█ magjed@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
oprypin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Chromium roll into WebRTC is blocked on iOS failures.

Project Member Reported by ehmaldonado@chromium.org, Jul 11 2017 
Chromium roll into WebRTC is blocked on iOS failures.

See https://codereview.webrtc.org/2979663003/ for example.

The compile step fails with
Full logs at https://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/21696/steps/compile/logs/stdio

  [1321/1324] CODE SIGNING //webrtc/examples:apprtcmobile_tests(//build/toolchain/mac:ios_clang_arm64)
  FAILED: apprtcmobile_tests.app/apprtcmobile_tests apprtcmobile_tests.app/Frameworks/XCTest.framework apprtcmobile_tests.app/Frameworks/IDEBundleInjection.framework 
  python ../../build/config/ios/codesign.py code-sign-bundle -t=iphoneos -i= -e=../../build/config/ios/entitlements.plist -b=obj/webrtc/examples/apprtcmobile_tests apprtcmobile_tests.app --disable-code-signature -F=/Applications/Xcode8.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/Frameworks/XCTest.framework -F=/Applications/Xcode8.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/PrivateFrameworks/IDEBundleInjection.framework
  apprtcmobile_tests.app: error: CFBundleExecutable value incorrect: AppRTCMobile != apprtcmobile_tests
  apprtcmobile_tests.app: error: CFBundleName value incorrect: AppRTCMobile != apprtcmobile_tests

Comment 1 by ehmaldonado@chromium.org, Jul 11 2017

Owner: sdefresne@chromium.org
Sylvain, we think this is because of https://chromium-review.googlesource.com/c/565401/
Can you help us take a look, please?

Comment 2 by sdefresne@chromium.org, Jul 11 2017 

This is because the target creating the Info.plist for apprtcmobile_tests is incorrect. It should set CFBundleExecutable and CFBundleName to apprtcmobile_tests.

Fixing this can probably be done by just making the following changes to webrtc/examples/objc/AppRTCMobile/ios/Info.plist:

$ git diff
diff --git a/webrtc/examples/objc/AppRTCMobile/ios/Info.plist b/webrtc/examples/objc/AppRTCMobile/ios/Info.plist
index 726f297db..48016b3a4 100644
--- a/webrtc/examples/objc/AppRTCMobile/ios/Info.plist
+++ b/webrtc/examples/objc/AppRTCMobile/ios/Info.plist
@@ -9,7 +9,7 @@
   <key>CFBundleDisplayName</key>
   <string>AppRTCMobile</string>
   <key>CFBundleExecutable</key>
-  <string>AppRTCMobile</string>
+  <string>${EXECUTABLE_NAME}</string>
   <key>CFBundleIcons</key>
   <dict>
     <key>CFBundlePrimaryIcon</key>
@@ -25,7 +25,7 @@
   <key>CFBundleInfoDictionaryVersion</key>
   <string>6.0</string>
   <key>CFBundleName</key>
-  <string>AppRTCMobile</string>
+  <string>${EXECUTABLE_NAME}</string>
   <key>CFBundlePackageType</key>
   <string>APPL</string>
   <key>CFBundleShortVersionString</key>
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/b8e7a7d7df47b8b5512c685bc371a7de28778d78

commit b8e7a7d7df47b8b5512c685bc371a7de28778d78
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 11 19:12:57 2017

Use correct value for CFBundleExecutable and CFBundleName.

NOTRY=True
TBR=magjed@webrtc.org

Bug:  chromium:740980 
Change-Id: I017c1632bf58aecad03ca8fb47ca09616bcb90c3
Reviewed-on: https://chromium-review.googlesource.com/567150
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18976}
[modify] https://crrev.com/b8e7a7d7df47b8b5512c685bc371a7de28778d78/webrtc/examples/objc/AppRTCMobile/ios/Info.plist
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/f1f9889c447d33dac25bfcfea0cc99f8cc817af0

commit f1f9889c447d33dac25bfcfea0cc99f8cc817af0
Author: buildbot <buildbot@webrtc.org>
Date: Tue Jul 11 21:28:37 2017

Roll chromium_revision 2c2aec8ef0..72d8fe0dd3 (485610:485684)

Change log: https://chromium.googlesource.com/chromium/src/+log/2c2aec8ef0..72d8fe0dd3
Full diff: https://chromium.googlesource.com/chromium/src/+/2c2aec8ef0..72d8fe0dd3

Changed dependencies:
* src/base: https://chromium.googlesource.com/chromium/src/base/+log/6d855f0574..1f504fa006
* src/build: https://chromium.googlesource.com/chromium/src/build/+log/2b042c14f0..7e59b44eb6
* src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/e138ea0ef3..7b25a7f38f
* src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/4f8f5ece0a..78c251f6c1
* src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/149c7500f3..22625e4eb8
* src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/260ac1d5dd..842d25d3f2
DEPS diff: https://chromium.googlesource.com/chromium/src/+/2c2aec8ef0..72d8fe0dd3/DEPS

No update to Clang.

TBR=
BUG= chromium:740980 
NOTRY=True
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/2980633002
Cr-Commit-Position: refs/heads/master@{#18977}

[modify] https://crrev.com/f1f9889c447d33dac25bfcfea0cc99f8cc817af0/DEPS

Comment 6 by ehmaldonado@chromium.org, Jul 11 2017

Labels: OS-Android OS-Mac
Status: Fixed (was: Untriaged)
►

Sign in to add a comment