Pagination Persistence in the AppListView |
|||||||
Issue descriptionSteps to Repro: Open the app list, go to fullscreen, swap to page >= 2. Close the app list. Open the app list, the app list is not on page 1. Desired Behavior: The app list is always on page 1 when switching from !FULLSCREEN_SEARCH to FULLSCREEN_ALL_APPS. Persist from search to All_apps.
,
Jul 25 2017
Taking this change.
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae73f2981f6f0c97d78756a2ebedef124cb2c3b0 commit ae73f2981f6f0c97d78756a2ebedef124cb2c3b0 Author: Maajid <maajid@chromium.org> Date: Wed Jul 26 16:39:05 2017 Make sure that pagination is not persisted for fullscreen app list. This change adds a test for the fullscreen app list which confirms the new behaviour, and adds a test for the old app list which confirms that there is no regression. Bug: 740975 Change-Id: I3dddbffdb3a4f33d8c9b7eeb2e86225a585be574 Reviewed-on: https://chromium-review.googlesource.com/585380 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#489667} [modify] https://crrev.com/ae73f2981f6f0c97d78756a2ebedef124cb2c3b0/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/ae73f2981f6f0c97d78756a2ebedef124cb2c3b0/ui/app_list/views/app_list_view_unittest.cc
,
Jul 26 2017
,
Jul 27 2017
,
Jul 28 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7077af29680b9d5a7c8a65831c0ac0ddc5ca2a79 commit 7077af29680b9d5a7c8a65831c0ac0ddc5ca2a79 Author: Maajid <maajid@chromium.org> Date: Mon Jul 31 21:02:52 2017 Make sure that pagination is not persisted for fullscreen app list. This change adds a test for the fullscreen app list which confirms the new behaviour, and adds a test for the old app list which confirms that there is no regression. TBR=maajid@chromium.org (cherry picked from commit ae73f2981f6f0c97d78756a2ebedef124cb2c3b0) Bug: 740975 Change-Id: I3dddbffdb3a4f33d8c9b7eeb2e86225a585be574 Reviewed-on: https://chromium-review.googlesource.com/585380 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489667} Reviewed-on: https://chromium-review.googlesource.com/594829 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#179} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/7077af29680b9d5a7c8a65831c0ac0ddc5ca2a79/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/7077af29680b9d5a7c8a65831c0ac0ddc5ca2a79/ui/app_list/views/app_list_view_unittest.cc
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by newcomer@chromium.org
, Jul 11 2017