+logan for "Ready for Review"

These also show up in the gerrit UI when you try to "show only comments" which makes finding real comments difficult there too.

Once the fix for  issue 6330  goes live (next week), we'll be able to push a client-side change to eliminate some redundant "ready for review" notifications.

Are you receiving email notifications for "-Commit-Queue" actions taken by Commit-Bot on behalf of other users?

I don't think this bug was ever about "unvoting" or "-Commit-Queue" actions.  Issue 6607  (moved to  http://crbug.com/740155  seems to cover that).

My main concern, which I believe to be a concern of others, is that a "dry run" ("Commit-Queue +1") sends an email to reviewers. It should not.

Perhaps this bug can be retitled to "A Dry Run / CommitQueue+1 should not send email.".  Or, at most, it should send an email to the user who clicked it and the CL author.

A dry run on Chrome takes 1-3 hours, and often fails. So -- once a CL has entered review -- these emails will bump any review follow-up 1-3 hours before it is ready for the reviewers to actually look at it. It's a big interruption to reviewer workflow.


(A bad workaround is perhaps to use `More -> WIP` to mark your CL a WIP each time a reviewer has commented on it, but really I don't get any benefit from the "I've started a dry run" emails -- it's the results I care about).

For some reason I'd assumed that the Commit-Queue+1 votes were being posted with notify=NONE, but I was wrong. That's up to chrome-infra to decide, so moving the issue over there.

Moved issue gerrit:6608 to now be  issue chromium:740969 .

Aaron - is this easy to fix? Our inboxes are getting flooded by dry run emails from all the patches we start reviewing.

I think the `Set Ready For Review` is also useless noise, since it always goes out with another email or two (i.e. "OWNER would like REVIEWER to review this change." plus (for most) "OWNER posted comments on this change. .. `Please review`").

See also https://groups.google.com/a/chromium.org/d/topic/chromium-dev/2RitTJb53_A/discussion

Yeah, I already started on it :D

Note that 'Set Ready For Review' is not being handled by this bug, other discussion above shows that being handled by logan@.

cl/161739662