Local NTP: Either fix or remove --local-ntp-reload |
|||
Issue description
Currently, the --local-ntp-reload flag doesn't work correctly because SendLocalFileResource doesn't fill in "{{CONFIG_INTEGRITY}}" and doesn't update the integrity attribute for local-ntp.js.
Related: bug 731027
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25dc05ccf7547ab780fef8bc29315fec9306945f commit 25dc05ccf7547ab780fef8bc29315fec9306945f Author: Marc Treib <treib@chromium.org> Date: Thu Jul 13 14:57:42 2017 Local NTP: Fix --local-ntp-reload When the --local-ntp-reload flag is enabled, strip out the integrity placeholders from the html file. (They're inconvenient to compute, and not required in this case, since CSP is already disabled.) Bug: 740964 Change-Id: I4a93c97db480ee92eb049b320f112b9ddfd2bc7d Reviewed-on: https://chromium-review.googlesource.com/568141 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#486380} [modify] https://crrev.com/25dc05ccf7547ab780fef8bc29315fec9306945f/chrome/browser/resources/local_ntp/local_ntp.html [modify] https://crrev.com/25dc05ccf7547ab780fef8bc29315fec9306945f/chrome/browser/search/local_files_ntp_source.cc [modify] https://crrev.com/25dc05ccf7547ab780fef8bc29315fec9306945f/chrome/browser/search/local_ntp_source.cc
,
Jul 13 2017
The flag works now. Still missing: The Google logo is inlined into the css by grit's flattenhtml feature. That of course doesn't run on the local files, so there the logo is missing.
,
Jul 21 2017
,
Oct 13 2017
Let's call this good enough. |
|||
►
Sign in to add a comment |
|||
Comment 1 by treib@chromium.org
, Jul 12 2017