|
|
|||||
Issue descriptionChrome Version : 61.0.3154.0 URLs (if applicable) : https://rbyers.github.io/sb/innerWidth.html What steps will reproduce the problem? (1) Open above URL (2) Pinch zoom on touchpad What is the expected result? Expect innerWidth to stay fixed at the layout viewport width. As part of inert visual viewport ( bug 489206 ) the pinch-zoom state should not be exposed to JS except via the Viewport API. What happens instead? Instead it updates to match the visual viewport width. , Jul 11 2017
, Jul 18 2017
, Jul 18 2017Also facing the same issue where innerWidth is not fixed when pinch-zoomed on my Android device running Chrome Canary 61.0.3160.0 , Jul 18 2017
Yup, there's a bug that affects all platforms, not just Mac. I should have a fix in today. , Jul 19 2017Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6933fe8a1b1d14e0d36a69cb27ef026217595d95 commit 6933fe8a1b1d14e0d36a69cb27ef026217595d95 Author: David Bokan <bokan@chromium.org> Date: Wed Jul 19 22:39:54 2017 Remove inert-visual-viewport flag (enabled by default) This patch removes the --enable-inert-visual-viewport flag from Chrome. This does *not* remove the inertVisualViewport setting from Blink. This feature is currently on by default but it was accidentally forced to the off state by the existence of the command line flag. By removing the flag, the Blink setting controls the status of this switch - which is currently set to on. Note: we're not losing anything as the feature is intended to be on by default and we didn't have a matching --disable-inert-visual-viewport flag so this flag would have been useless as of M61. This patch fixes some tests that were expecting the flag to be off and removes others that were explicitly testing behavior of the flag when disabled. I also added a new test to test the new flag-on behavior. This also exposed a bug in document.rootScroller, window's scrollX and scrollY properties reverted to returning the FrameView's rather than the rootScroller's scroll offset. This was caught by the set-root-scroller.html test, I've commented out the checks (rootScroller isn't yet shipped), and I'll fix the behavior in a followup patch. Bug: 740956 Change-Id: I249a34b4ee67dfbe8230e6bc3048871a6325e43d Reviewed-on: https://chromium-review.googlesource.com/575768 Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488018} [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/chrome/browser/about_flags.cc [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/content/browser/renderer_host/render_view_host_impl.cc [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/content/public/common/common_param_traits_macros.h [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/content/public/common/content_switches.cc [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/content/public/common/content_switches.h [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/content/public/common/web_preferences.cc [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/content/public/common/web_preferences.h [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/content/renderer/render_view_impl.cc [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [delete] https://crrev.com/df848adb8eb6bf9be13ed82e1b2156b8ae93615a/third_party/WebKit/LayoutTests/fast/dom/Window/window-scaled-viewport-properties.html [add] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-scale-inert.html [delete] https://crrev.com/df848adb8eb6bf9be13ed82e1b2156b8ae93615a/third_party/WebKit/LayoutTests/fast/dom/window-inner-size-scaling.html [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/third_party/WebKit/LayoutTests/fast/rootscroller/set-root-scroller.html [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/third_party/WebKit/LayoutTests/paint/invalidation/fixed-right-bottom-in-page-scale.html [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/third_party/WebKit/Source/core/exported/WebSettingsImpl.cpp [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/third_party/WebKit/Source/core/exported/WebSettingsImpl.h [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/6933fe8a1b1d14e0d36a69cb27ef026217595d95/third_party/WebKit/public/web/WebSettings.h , Jul 19 2017
This should be fixed in the next Canary update. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rbyers@chromium.org, Jul 11 2017