https://chromium.googlesource.com/chromium/src/+/fdacb19a2600b6ca47c7d58752a97bc075fd89f5 This CL introduced a new static initializer. Many other CLs have reduced this number. Is it really necessary?
All graphs for this bug: https://chromeperf.appspot.com/group_report?bug_id=740955 (For debugging:) Original alerts at time of bug-filing: https://chromeperf.appspot.com/group_report?sid=85edf4847670de36f1f1d3697774cb78db11cf0a7ece897538ff80b652fc5a0c Bot(s) for this bug's original alert(s): Android Builder
AFAIR the policy is to revert newly coming static initializers ASAP.
Yup.
Revert created: https://crrev.com/2974243002
Revert landed. Sent email to binary size sheriffs to enforce policy of reverting new static initializers. Thanks for clarifying!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/422a878152e9cbada622e6e7f6cfc98d60af96b0 commit 422a878152e9cbada622e6e7f6cfc98d60af96b0 Author: hkamila <hkamila@google.com> Date: Wed Jul 12 02:51:08 2017 -Added the experimental features section as part of the chrome://safe-browsing. For the experiments not running at 100%. -Exported the list of SafeBrowsing features (base::Feature) to have them in the future in a central location. -Fixed the message dialogue for the WebUI. -Added some extra css. Note: Tags for the experiments are not added in this issue. Review-Url: https://codereview.chromium.org/2964693003 Cr-Commit-Position: refs/heads/master@{#485380} Committed: https://chromium.googlesource.com/chromium/src/+/fdacb19a2600b6ca47c7d58752a97bc075fd89f5 BUG= 740955 , 734667 Review-Url: https://codereview.chromium.org/2964693003 Cr-Commit-Position: refs/heads/master@{#485821} [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/chrome/renderer/safe_browsing/DEPS [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/chrome/renderer/safe_browsing/threat_dom_details_browsertest.cc [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/chrome/test/BUILD.gn [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/resources/safe_browsing_resources.grdp [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/BUILD.gn [add] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/features.cc [add] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/features.h [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/renderer/BUILD.gn [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/renderer/DEPS [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/renderer/threat_dom_details.cc [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/renderer/threat_dom_details.h [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/BUILD.gn [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/resources/safe_browsing.css [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/resources/safe_browsing.html [add] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/resources/safe_browsing.js [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/safe_browsing_ui.cc [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/safe_browsing_ui.h [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing_db/BUILD.gn [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing_db/DEPS [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing_db/v4_feature_list.cc
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 11 2017