New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740955 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1 new static initializer (MonochromePublic.apk) at 485380:485380

Project Member Reported by wnwen@google.com, Jul 11 2017

Issue description

https://chromium.googlesource.com/chromium/src/+/fdacb19a2600b6ca47c7d58752a97bc075fd89f5

This CL introduced a new static initializer. Many other CLs have reduced this number. Is it really necessary?
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 11 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=740955

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=85edf4847670de36f1f1d3697774cb78db11cf0a7ece897538ff80b652fc5a0c


Bot(s) for this bug's original alert(s):

Android Builder

Comment 2 by wnwen@chromium.org, Jul 11 2017

Cc: pasko@chromium.org vakh@chromium.org hkamila@google.com
Owner: blundell@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 11 2017

Labels: Hotlist-Google

Comment 4 by pasko@chromium.org, Jul 11 2017

Cc: pkasting@chromium.org thakis@chromium.org
AFAIR the policy is to revert newly coming static initializers ASAP.

Comment 5 by thakis@chromium.org, Jul 11 2017

Yup.

Comment 6 by wnwen@chromium.org, Jul 11 2017

Revert created: https://crrev.com/2974243002

Comment 7 by wnwen@chromium.org, Jul 11 2017

Cc: blundell@chromium.org
Owner: wnwen@chromium.org
Status: Fixed (was: Assigned)
Revert landed.

Sent email to binary size sheriffs to enforce policy of reverting new static initializers. Thanks for clarifying!
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/422a878152e9cbada622e6e7f6cfc98d60af96b0

commit 422a878152e9cbada622e6e7f6cfc98d60af96b0
Author: hkamila <hkamila@google.com>
Date: Wed Jul 12 02:51:08 2017

-Added the experimental features section as part of the chrome://safe-browsing. For the experiments not running at 100%.

-Exported the list of SafeBrowsing features (base::Feature) to have them in the future in a central location.

-Fixed the message dialogue for the WebUI.

-Added some extra css.

Note: Tags for the experiments are not added in this issue.
Review-Url: https://codereview.chromium.org/2964693003
Cr-Commit-Position: refs/heads/master@{#485380}
Committed: https://chromium.googlesource.com/chromium/src/+/fdacb19a2600b6ca47c7d58752a97bc075fd89f5

BUG= 740955 , 734667 

Review-Url: https://codereview.chromium.org/2964693003
Cr-Commit-Position: refs/heads/master@{#485821}

[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/chrome/renderer/safe_browsing/DEPS
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/chrome/renderer/safe_browsing/threat_dom_details_browsertest.cc
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/chrome/test/BUILD.gn
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/resources/safe_browsing_resources.grdp
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/BUILD.gn
[add] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/features.cc
[add] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/features.h
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/renderer/BUILD.gn
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/renderer/DEPS
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/renderer/threat_dom_details.cc
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/renderer/threat_dom_details.h
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/BUILD.gn
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/resources/safe_browsing.css
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/resources/safe_browsing.html
[add] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/resources/safe_browsing.js
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/safe_browsing_ui.cc
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/safe_browsing_ui.h
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing_db/BUILD.gn
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing_db/DEPS
[modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing_db/v4_feature_list.cc

Sign in to add a comment