Issue metadata
Sign in to add a comment
|
git cl split doesn't work anymore - --send-email |
||||||||||||||||||||||
Issue description
git cl split # fails:
$ git cl split --description=$HOME/scratch/cl-description
Will split current branch (get-rid-of-set-automation-id) in 25 CLs.
Uploading CL for content/browser.
Usage: git cl [options]
git cl: error: no such option: --send-email
,
Jul 12 2017
,
Jul 13 2017
There has never been a "--send-email" option; it is "--send-mail" or "-s".
,
Jul 14 2017
Fixing this was easy enough: https://chromium-review.googlesource.com/c/572031/ https://chromium-review.googlesource.com/c/572033/
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/636b13fc3deba4b3f74a77a9c493dd8a830e5c48 commit 636b13fc3deba4b3f74a77a9c493dd8a830e5c48 Author: Aaron Gable <agable@chromium.org> Date: Fri Jul 14 19:13:04 2017 Let Changelist().AddComment() mark changes as Ready In Rietveld, adding a comment to a change automatically published it no matter what. In Gerrit, we need to explicitly mark the change as Ready for Review. This CL adds a new parameter to the wrapper methods around the SetReview API so that they can mark changes as Ready. Bug: 740950 Change-Id: Icb2ad7c5beb03a4760657a761841745f0d75514e Reviewed-on: https://chromium-review.googlesource.com/572031 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/636b13fc3deba4b3f74a77a9c493dd8a830e5c48/tests/git_cl_test.py [modify] https://crrev.com/636b13fc3deba4b3f74a77a9c493dd8a830e5c48/git_cl.py [modify] https://crrev.com/636b13fc3deba4b3f74a77a9c493dd8a830e5c48/gerrit_util.py
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e5adf6126612b31178d01e43a1dc20ef05bdda89 commit e5adf6126612b31178d01e43a1dc20ef05bdda89 Author: Aaron Gable <agable@chromium.org> Date: Fri Jul 14 21:51:19 2017 Fix typo with --send-email [sic] flags The actual flag is --send-mail. Also includes a fix to publish these changes if a comment is included. Bug: 740950 Change-Id: I38ca0a35c1364c8364eb0ef301137c04daede40b Reviewed-on: https://chromium-review.googlesource.com/572033 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/e5adf6126612b31178d01e43a1dc20ef05bdda89/git_cl.py [modify] https://crrev.com/e5adf6126612b31178d01e43a1dc20ef05bdda89/split_cl.py
,
Jul 14 2017
,
Jul 17 2017
Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lukasza@chromium.org
, Jul 11 2017Labels: Proj-Gerrit-Migration