Add haptic feedback on site and username copy in iOS settings |
|||||
Issue descriptionCurrently, in passwords settings, haptic feedback is given during copying password but not during copying any of the other less sensitive data (site and username). Bug 696634 hints at, and pinkerton@ confirmed, that the idea for haptic feedback was to accompany all MD toasts in the UI. pschaffner@ confirmed on https://chromium-review.googlesource.com/c/567152 that that's a good idea for the passwords settings as well.
,
Jul 12 2017
This has been clarified in a discussion on https://chromium-review.googlesource.com/c/567152 and the goal is now to add haptic feedback to the copy operations for site and username as well.
,
Jul 12 2017
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5201a681d04dc0fefdfca0b1eca8b3df2e40c9eb commit 5201a681d04dc0fefdfca0b1eca8b3df2e40c9eb Author: Vaclav Brozek <vabr@chromium.org> Date: Wed Jul 12 21:50:41 2017 [iOS passwords settings] Tie haptic feedback to all copy toasts Currently, in passwords settings, haptic feedback is given during copying password but not during copying any of the other less sensitive data (site and username). https://crbug.com/696634 hints at, and pinkerton@ confirmed, that the idea for haptic feedback was to accompany all MD toasts in the UI. pschaffner@ confirmed on this CL that that's a good idea for the passwords settings as well. Therefore, this CL adds the haptic feedback to the site and username copy toasts. Those copies always succeed, because there is no reauthentication to be done, so the feedback is always a successful one. Bug: 740948 Change-Id: Ie282499eb5095cabeb4d8349f6231ae653f01f6a Reviewed-on: https://chromium-review.googlesource.com/567152 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#486107} [modify] https://crrev.com/5201a681d04dc0fefdfca0b1eca8b3df2e40c9eb/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm
,
Jul 13 2017
The haptic feedback should now happen on every copy action in the password settings. My device (iPhone 5S) does not seem to have any haptic abilities, so I cannot test. If anyone finds more issues (starting with tomorrow's canary), please let me know.
,
Jul 14 2017
It requires an iPhone7 or better to be able to test. To clarify, we added haptics for HUD display throughout the app, and copying passwords show a HUD, thus the feedback.
,
Sep 22 2017
Verified (#3) on iOS 10.3.3, 11.0 on iPhone 6 +, iPhone 7+, iPad Pro 12'5 on build 62.0.3202.29 Beta. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vabr@chromium.org
, Jul 11 2017