Content suggestions should reload when using pull-to-refresh if stale |
||
Issue descriptionM61dev iPhone7 - Have an NTP open, background the app overnight or for a day or two - Return to the NTP - See old, stale content suggestions (this is expected) - Pull to refresh NTP expected: - Updated content suggestions actual: - Nothing changes Opening a new NTP will immediately show the fresh suggestions, but pull to refresh should achieve the same thing.
,
Jul 26 2017
A way to test it without waiting for a day: On iPhone plus only. 1. Open a NTP in landscape with some unread articles 2. Open the Reading List 3. Mark read articles unread or mark unread articles read (the top 3 unread articles should be changed) 4. Close Reading List 5. Make sure the Reading List articles display on the NTP are the one on step #1 6. Pull to refresh Expected: The new Reading List pages should be displayed
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e101fdb2fbae25b04b7cb190ee5a5c882d65503 commit 0e101fdb2fbae25b04b7cb190ee5a5c882d65503 Author: gambard <gambard@chromium.org> Date: Wed Jul 26 09:41:13 2017 Pull-to-refresh reloads the suggestions When the pull-to-refresh overscroll action is used, the suggestions should be reloaded. If the suggestions are stale, the gesture will update the content. Bug: 740932 , 700375 Change-Id: I4c811c2d57d2b8ba78c3f1cad33e9466eda4a135 Reviewed-on: https://chromium-review.googlesource.com/585010 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#489581} [modify] https://crrev.com/0e101fdb2fbae25b04b7cb190ee5a5c882d65503/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
,
Jul 26 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by fi...@chromium.org
, Jul 21 2017