New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740920 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
OOO until 2019-02-10
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.5%-16.6% regression in system_health.memory_desktop at 484492:484835

Project Member Reported by petermarshall@chromium.org, Jul 11 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 11 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=740920

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=a064eaa4715f4d5a0c83ef017069a2116cd46617c755e19ad67da78cfab863a7


Bot(s) for this bug's original alert(s):

chromium-rel-mac11-air
chromium-rel-mac12
chromium-rel-mac12-mini-8gb
chromium-rel-win7-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 11 2017

Cc: bmeu...@chromium.org
Owner: bmeu...@chromium.org

=== Auto-CCing suspected CL author bmeurer@chromium.org ===

Hi bmeurer@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Benedikt Meurer
  Commit : b9ee0657c6a0b7504d8bf3630e41923d5a72c71f
  Date   : Thu Jul 06 11:55:14 2017
  Subject: [builtins] Unified C++ implementation of Map and Set iterators.

Bisect Details
  Configuration: mac_10_12_mini_8gb_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/load_news/load_news_hackernews
  Change       : 10.51% | 3156024.0 -> 3487797.33333

Revision                           Result                  N
chromium@484580                    3156024 +- 0.0          6      good
chromium@484612                    3156024 +- 0.0          6      good
chromium@484616                    3162565 +- 22659.8      6      good
chromium@484618                    3159191 +- 22028.7      6      good
chromium@484618,v8@124ff5322d      3156024 +- 0.0          6      good
chromium@484618,v8@b9ee0657c6      3522232 +- 238566       6      bad       <--
chromium@484618,v8@b520c6ed5e      3453373 +- 24.4404      6      bad
chromium@484619                    3453367 +- 23.7767      6      bad
chromium@484620                    3487805 +- 188586       6      bad
chromium@484628                    3453369 +- 26.3312      6      bad
chromium@484644                    3453368 +- 19.5959      6      bad
chromium@484708                    3487799 +- 188611       6      bad
chromium@484835                    3487797 +- 188595       6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.hackernews system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8974364035778706800


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jul 11 2017

 Issue 740921  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jul 11 2017

 Issue 740917  has been merged into this issue.
Cc: mlippautz@chromium.org
Status: Assigned (was: Untriaged)
This looks like we get another code page. Can happen on any CL if we're close to the limit.

mlippautz@ am I reading this correctly?
Actually, picking out load_news/load_news_hackerners in [1] this looks like it is not CODE_SPACE but OLD_SPACE. Which also makes sense considering that GC times (e.g. Scavenger) on other benchmarks regressed. 

To me this looks like more memory traffic.

[1]: https://chromeperf.appspot.com/report?sid=d1745bd193705ab0fe2e38a4c7d414c1877940085c204bec00e0170f3b60d8fd
Owner: petermarshall@chromium.org
After offline discussion with mlippautz@: Assigning to memory sheriff for bisection and investigation.
Status: WontFix (was: Assigned)
We looked into this, there appears to be something funny going on with how the statistics are collected, but it does indeed look like we are just on the edge of a page limit, so happy to close as won't fix.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Jul 13 2017

 Issue 740915  has been merged into this issue.

Sign in to add a comment