New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740901 link

Starred by 2 users
Status: Fixed
Owner:
jkrcal@chromium.org
Closed: Jul 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 2
Type: Bug



Sign in to add a comment

[Remote suggestions] Scheduler should handle offline state well.

Project Member Reported by jkrcal@chromium.org, Jul 11 2017 
Currently, if the scheduler gets a soft signal when offline, it still triggers the fetch. The fetch immediately fails and we store its time as the last time of a fetch attempt. Thus, we won't try to fetch for a while afterwards.

It is still important to decide about fetches based on the last fetch _attempt_ and not the last successful fetch (to avoid burning the servers if there are any issues).

We should handle offline state separately.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d8795d258dc20536958b28ea66da27feca5fb6b

commit 9d8795d258dc20536958b28ea66da27feca5fb6b
Author: Jan Krcal <jkrcal@chromium.org>
Date: Tue Jul 11 16:26:46 2017

[Remote scheduler] Handle offline state gracefully

Currently, if the scheduler gets a soft signal when offline, it still
triggers the fetch. The fetch immediately fails and we store its time as
the last time of a fetch attempt. Thus, we won't try to fetch for a
while afterwards.

This CL fixes the problem by handling the offline state separately.

Because persistent fetches are only triggered when online, this fix is
especially important after replacing most persistent fetches by
startup soft fetches.

Bug:  740901 
Change-Id: Iea4df04ab63f76ed6f233a532220fc21c099cac0
Reviewed-on: https://chromium-review.googlesource.com/566830
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485647}
[modify] https://crrev.com/9d8795d258dc20536958b28ea66da27feca5fb6b/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc
[modify] https://crrev.com/9d8795d258dc20536958b28ea66da27feca5fb6b/components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc

Comment 2 by fi...@chromium.org, Jul 20 2017

Labels: M-62 zine-triaged

Comment 3 by jkrcal@chromium.org, Jul 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment