CL related to ContentSuggestions without a specific bug can use this to track it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da8bfd3e73a70fea124ff8d4ca5757771597f1ab commit da8bfd3e73a70fea124ff8d4ca5757771597f1ab Author: gambard <gambard@chromium.org> Date: Tue Jul 11 11:28:54 2017 Add finch experiment for ContentSuggestions Bug: 740894 Change-Id: I2ecd9902237fa558caae6f49a77bb2ce7022e5ea Reviewed-on: https://chromium-review.googlesource.com/566801 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#485587} [modify] https://crrev.com/da8bfd3e73a70fea124ff8d4ca5757771597f1ab/ios/chrome/browser/experimental_flags.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45c11678e66854d2c021025f5d7860bd1b07789a commit 45c11678e66854d2c021025f5d7860bd1b07789a Author: gambard <gambard@chromium.org> Date: Thu Jul 13 08:06:43 2017 Move ContentSuggestions image fetching to Mediator The fetching of the image for the ContentSuggestions Articles should be done in the mediator to respect the layer separation between UI and mediator. Bug: 740894 Change-Id: I89fc5098d99f46da0150d9b391c204a0b492ec9d Reviewed-on: https://chromium-review.googlesource.com/567517 Reviewed-by: Louis Romero <lpromero@chromium.org> Reviewed-by: Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#486313} [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item_unittest.mm [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_whats_new_item.h [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_whats_new_item.mm [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_whats_new_item_unittest.mm [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/chrome/browser/ui/content_suggestions/cells/suggested_content.h [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h [delete] https://crrev.com/d87cff38b9bb0a936e5a15f9b1f64a4e6d88980a/ios/chrome/browser/ui/content_suggestions/content_suggestions_image_fetcher.h [add] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/showcase/content_suggestions/OWNERS [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/showcase/content_suggestions/sc_content_suggestions_data_source.mm [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/showcase/content_suggestions/sc_content_suggestions_item.h [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/showcase/content_suggestions/sc_content_suggestions_item.mm [modify] https://crrev.com/45c11678e66854d2c021025f5d7860bd1b07789a/ios/showcase/content_suggestions/sc_content_suggestions_most_visited_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07a3fb28a3b707308b5d356de4f1a64f01c335c8 commit 07a3fb28a3b707308b5d356de4f1a64f01c335c8 Author: gambard <gambard@chromium.org> Date: Wed Jul 26 09:41:40 2017 Prevent Learn More cell from being dismissed Bug: 740894 Change-Id: Id7ebac784b30d7dd95290177aab61b925e9fc873 Reviewed-on: https://chromium-review.googlesource.com/584873 Reviewed-by: Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#489582} [modify] https://crrev.com/07a3fb28a3b707308b5d356de4f1a64f01c335c8/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/498754f5eb5c30163871a4f41f42dd877c4c72ca commit 498754f5eb5c30163871a4f41f42dd877c4c72ca Author: gambard <gambard@chromium.org> Date: Fri Aug 11 08:40:39 2017 Use blue instead of branded color for spinner While more suggestions are fetched, a spinner is displayed. If the branded color are used, the color displayed are blue then red and the suggestions are fetched, stoping the spinner. So from a visual point of view the color are blue->red, which looks like it is a failure. This is because the fetch is too fast, and the other colors don't have time to be displayed. Switching to blue only prevents this. Bug: 740894 Change-Id: I766ef8f6394e87c2486078eb1dfee177aa68f079 Reviewed-on: https://chromium-review.googlesource.com/611982 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#493687} [modify] https://crrev.com/498754f5eb5c30163871a4f41f42dd877c4c72ca/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_footer_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/697d411856448ae6b5e66ae86ced84565e7c8ef0 commit 697d411856448ae6b5e66ae86ced84565e7c8ef0 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Sep 01 09:00:35 2017 Test tapping promo Add a test to the NTP to tap on the promo displayed and ensure that the promo is correctly removed. Bug: 761004, 740894 Change-Id: I45ac067d5b6e1ed7e74336f4b04c35e88b12951d Reviewed-on: https://chromium-review.googlesource.com/645955 Reviewed-by: Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#499155} [modify] https://crrev.com/697d411856448ae6b5e66ae86ced84565e7c8ef0/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_whats_new_item.h [modify] https://crrev.com/697d411856448ae6b5e66ae86ced84565e7c8ef0/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_whats_new_item.mm [modify] https://crrev.com/697d411856448ae6b5e66ae86ced84565e7c8ef0/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b825de7f14cbc2f528f6ce90e590b548a3a71c7 commit 3b825de7f14cbc2f528f6ce90e590b548a3a71c7 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 07 07:10:21 2017 Follow up on promo EG test Take into account gchatz comments on crrev.com/c/645955. Using MigrateUserPrefs instead of resetting the object is much more efficient. Bug: 740894 Change-Id: I1e4257f183fda879adbac14a079bc757e8017b77 Reviewed-on: https://chromium-review.googlesource.com/648929 Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#500239} [modify] https://crrev.com/3b825de7f14cbc2f528f6ce90e590b548a3a71c7/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
Comment 1 by gambard@chromium.org
, Jul 11 2017