New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740890 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Error messages appear to js console when hovering over available Drive space

Project Member Reported by yamaguchi@chromium.org, Jul 11 2017

Issue description

Chrome Version: 61.0.3148.0

Steps To Reproduce:
(1) Open Files app.
(2) [Ctrl]+[Shift]+[J] to open developer console.
(3) Open "settings" menu of the app. (the three-dots icon button in the action bar)
(4) Hover pointer on the available Drive space (the last item in the list that says like "3.3GB available").

Expected Result:
No errors.

Actual Result:
Unchaught Error: Assertion failed: Value [object HTMLDivElement] is not a[n] f


How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?
No impact.
 
Description: Show this description
Summary: Error messages when hovering over available Drive space (was: Error messages when hovering on available Drive space)
Summary: Error messages appear to js console when hovering over available Drive space (was: Error messages when hovering over available Drive space)
Labels: -Pri-2 Pri-3

Comment 5 by fukino@chromium.org, Jul 19 2017

Owner: klemenko@google.com
Status: Assigned (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c9dc07aa48293f68e8ab93a735efcd132b6b4d4

commit 5c9dc07aa48293f68e8ab93a735efcd132b6b4d4
Author: Klemen Kozjek <klemenko@google.com>
Date: Wed Jul 19 09:27:27 2017

Files app: Prevent to 'available Drive space' triggers the onMouseOver event for MenuItem

This CL stops propagation of events on 'available Drive space' on mouse over event.
As a result, when mouse goes over the 'available Drive space' it does not trigger onMouseOver for MenuItem and therefore error does not appear.

Bug:  740890 
Change-Id: I4bec80aad0c4c9155fec5668d5bd8cef8e8a0e7b
Reviewed-on: https://chromium-review.googlesource.com/577490
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487801}
[modify] https://crrev.com/5c9dc07aa48293f68e8ab93a735efcd132b6b4d4/ui/file_manager/file_manager/foreground/js/gear_menu_controller.js
[modify] https://crrev.com/5c9dc07aa48293f68e8ab93a735efcd132b6b4d4/ui/file_manager/file_manager/foreground/js/ui/gear_menu.js

Comment 7 by klemenko@google.com, Jul 19 2017

Status: Fixed (was: Assigned)
Cc: mkarkada@chromium.org dhadd...@chromium.org
Status: Verified (was: Fixed)
Verified on M62 (Chrome OS 9817.0.0, 62.0.3176.0 dev build).

Sign in to add a comment