New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740887 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

md-select misaligned due to md-select-underline

Project Member Reported by dullweber@chromium.org, Jul 11 2017

Issue description

It seems like most (all?) md-select are not aligned properly with their label.
The issue is that md-select-underline has a height of 3px, which shifts the md-select up by 1.5px when centered.

Screenshots from chrome://settings and chrome://settings/clearBrowsingData
 
Screenshot from 2017-07-11 12:49:32.png
2.6 KB View Download
Screenshot from 2017-07-11 12:49:04.png
3.7 KB View Download
Cc: dpa...@chromium.org
I created a fix for this: http://crrev.com/c/566826
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9f72053995eec1a97ac3cef567ca65e7414f29a

commit e9f72053995eec1a97ac3cef567ca65e7414f29a
Author: Christian Dullweber <dullweber@chromium.org>
Date: Mon Jul 17 10:56:13 2017

Fix unbalanced md-select is not centered

md-select is not aligned with its label due to unbalanced paddings 
and a 3px md-select-underline. This Cl fixes this by balancing 
md-select with an additional margin-top and reducing the height of 
md-select-underline to 0px + 1px border.

Bug:  740887 
Change-Id: I1b8a5b6bea9c30a686427fdffb96ee05df686259
Reviewed-on: https://chromium-review.googlesource.com/566826
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487040}
[modify] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/ui/webui/resources/html/md_select_css.html

Owner: dullweber@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment