Issue metadata
Sign in to add a comment
|
7.9%-15.2% regression in system_health.memory_mobile at 485157:485157 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 11 2017
Directly points to 4c03f6e Support child non-exo windows of the root surface in exo::SurfaceTreeHost
,
Jul 11 2017
My change shouldn't affect to Android Chrome, since components/exo is built only on ChromeOS build. https://chromium.googlesource.com/chromium/src/+log/4c03f6e2c0c72aea643810a67360057efbd31b13%5E..4c03f6e2c0c72aea643810a67360057efbd31b13?pretty=fuller Is my change really the cause of the memory regression?
,
Jul 11 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8974357621714044336
,
Jul 11 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : perezju Commit : 00b0c16c97088f5c06df9d3b27eaeb41f06173e5 Date : Sat Jul 08 09:18:52 2017 Subject: Revert of [System Health] Extend dump time to 5 seconds (patchset #2 id:20001 of https://codereview.chromium.org/2946013004/ ) Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/load_tools/load_tools_drive Change : 14.81% | 15253168.8 -> 17512246.0 Revision Result N chromium@485130 15253169 +- 129084 5 good chromium@485145 15208034 +- 464703 9 good chromium@485146 15298493 +- 382905 9 good chromium@485146,catapult@00b0c16c97 17088919 +- 2031580 9 bad <-- chromium@485147 17259566 +- 2155143 6 bad chromium@485149 17340731 +- 2431351 9 bad chromium@485153 16662434 +- 6265650 14 bad chromium@485160 17308771 +- 2128067 9 bad chromium@485190 17512246 +- 415659 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.tools.drive system_health.memory_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8974357621714044336 For feedback, file a bug with component Speed>Bisection |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 11 2017