New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740879 link

Starred by 5 users
Status: Fixed
Owner:
chaopeng@chromium.org
Closed: Nov 2017
Cc:
ajha@chromium.org
chaopeng@chromium.org
█ kavvaru@chromium.org
█ sandeepkumars@chromium.org
█ brajkumar@chromium.org
bokan@chromium.org
jmukthavaram@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Scrollbar should recreate when native scrollbar theme change.

Project Member Reported by divya.pa...@techmahindra.com, Jul 11 2017 
Chrome Version: 61.0.3153.4
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1)Launch chrome>> Navigate to chrome://settings/
(2)Press"F12" and click on toggle device toolbar>> change the font to very large then set to Responsive, 150% and online
(3)Scroll the page to the extreme top,bottom,right and left by using the mouse and navigate to other settings(Eg: Manage search engines) and observe

Expected 
Scrollbar should not disappear

Actual
Scrollbar disappears

This is a regression issue broken in M-61. 
===============================
Manual Bisect info:
Good Build: 61.0.3122.0 
Bad Build: 61.0.3123.0 

Note: This issue does not exist on windows behaviour
Actual_Toogle.scrollbar.ogv
9.9 MB View Download
Expected_toggle.scrollbar.ogv
6.3 MB View Download

Comment 1 by divya.pa...@techmahindra.com, Jul 11 2017

Description: Show this description

Comment 2 by krajshree@chromium.org, Jul 11 2017

Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Ubuntu 14.04 using chrome version #61.0.3153.0.
Issue is not seen in OS-Mac

Comment 3 by jmukthavaram@chromium.org, Jul 11 2017

Cc: jmukthavaram@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: chaopeng@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on Linux ubuntu 14.04 using chrome #61.0.3153.4.
Manual bisect info:
------------------
Good Build: 61.0.3122.0 -Revision-477124
Bad Build: 61.0.3123.0  -Revision-477506

Per revision bisect info:
------------------------
You are probably looking for a change made after 477286 (known good), but no later than 477287 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/5af488e3095f444e1ec680c7b89dfee2c772b35b..4795906652460b283e526e6745057d77f0133980

Possible suspect:
----------------
https://chromium.googlesource.com/chromium/src/+/4795906652460b283e526e6745057d77f0133980

chaopeng@Could you please take a look into this issue.
Thanks..!!

Comment 4 by chaopeng@chromium.org, Jul 11 2017

Cc: bokan@chromium.org
For my understand, this 2 videos both works incorrect.

1. The chrome://settings page has html {overflow: hidden;} to prevent showing the scrollbar.
2. On my Linux, the page before toggle devtools is not showing any scrollbar.
3. If showing android scrollbar should be thin not draggable.

Comment 5 by bokan@chromium.org, Jul 11 2017 

Yup, both videos are showing bugs. It looks like we're mixing the behavior and style of overlay and non-overlay scrollbars. My guess would be we're flipping the "IsOverlayScrollbar" bit on the ScrollbarTheme but we don't actually rebuild the scrollbars so they're still the classic style. Seems we may need to do a bit of extra work when toggling emulation to make sure we clear all the previous scrollbar state.

Comment 6 by chaopeng@chromium.org, Aug 24 2017

Summary: Scrollbar should recreate when native scrollbar theme change. (was: Regression: On Devtools when switch to toggle, scroll bar disappears)

Comment 7 Deleted

Comment 8 by chaopeng@chromium.org, Aug 30 2017 

The scrollbar got incorrect recreated. we can reproduce in a simple page.
http://ht.chaopeng.me/bgcolor/colorful.html

All scrollbars in div/iframe are not correct after enter/exit mobile emulator.

Comment 9 by bokan@chromium.org, Oct 20 2017

Blockedon: 775541

Comment 10 by chaopeng@chromium.org, Oct 20 2017

Blockedon: -775541
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e49403327faee603266393f4ca6ddbd07a6f5a50

commit e49403327faee603266393f4ca6ddbd07a6f5a50
Author: chaopeng <chaopeng@chromium.org>
Date: Mon Nov 06 03:43:13 2017

Set proper settings for mobile emulator overlay scrollbar.

This issue is caused by mobile emulator does not set proper settings.

1. solid_color_scrollbar need to be true to create animation controller.
2. Need to use correct scrollbar theme for FrameView and PLSA.

After this patch, when toggle mobile emulator, scrollbar will paint
animating as Android Scrollbar.

Bug:  740879 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2cedba08609e9c0d2f06d26ec2ca92d508f83c48
Reviewed-on: https://chromium-review.googlesource.com/646727
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514085}
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/LayoutTests/platform/mac/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/LayoutTests/platform/win/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/Source/core/frame/Settings.json5
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/Source/core/inspector/DevToolsEmulator.h
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp
[modify] https://crrev.com/e49403327faee603266393f4ca6ddbd07a6f5a50/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c303730a09633e57a1af74b2643230a9a11e0f9e

commit c303730a09633e57a1af74b2643230a9a11e0f9e
Author: meade_UTC10 <meade@chromium.org>
Date: Mon Nov 06 05:16:20 2017

Revert "Set proper settings for mobile emulator overlay scrollbar."

This reverts commit e49403327faee603266393f4ca6ddbd07a6f5a50.

Reason for revert: Caused failure of All/ScrollbarsTest.NativeScrollbarChangeToMobileByEmulator on WebKit Android (Nexus4).

First failing build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/71093

Original change's description:
> Set proper settings for mobile emulator overlay scrollbar.
> 
> This issue is caused by mobile emulator does not set proper settings.
> 
> 1. solid_color_scrollbar need to be true to create animation controller.
> 2. Need to use correct scrollbar theme for FrameView and PLSA.
> 
> After this patch, when toggle mobile emulator, scrollbar will paint
> animating as Android Scrollbar.
> 
> Bug:  740879 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I2cedba08609e9c0d2f06d26ec2ca92d508f83c48
> Reviewed-on: https://chromium-review.googlesource.com/646727
> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#514085}

TBR=dgozman@chromium.org,bokan@chromium.org,rprosamaria383@gmail.com,pdr@chromium.org,caseq@chromium.org,pfeldman@chromium.org,chaopeng@chromium.org

Change-Id: Ibb96051275cdc875a2c096242491951b4c8dcf84
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  740879 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/753544
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514088}
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/LayoutTests/platform/mac/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/LayoutTests/platform/win/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/Source/core/frame/Settings.json5
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/Source/core/inspector/DevToolsEmulator.h
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp
[modify] https://crrev.com/c303730a09633e57a1af74b2643230a9a11e0f9e/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdedc4157e6ed69510703082514039a6d37a1d12

commit cdedc4157e6ed69510703082514039a6d37a1d12
Author: chaopeng <chaopeng@chromium.org>
Date: Wed Nov 08 17:49:35 2017

Reland "Set proper settings for mobile emulator overlay scrollbar."

This is a reland of e49403327faee603266393f4ca6ddbd07a6f5a50
Original change's description:
> Set proper settings for mobile emulator overlay scrollbar.
>
> This issue is caused by mobile emulator does not set proper settings.
>
> 1. solid_color_scrollbar need to be true to create animation controller.
> 2. Need to use correct scrollbar theme for FrameView and PLSA.
>
> After this patch, when toggle mobile emulator, scrollbar will paint
> animating as Android Scrollbar.
>
> Bug:  740879 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I2cedba08609e9c0d2f06d26ec2ca92d508f83c48
> Reviewed-on: https://chromium-review.googlesource.com/646727
> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#514085}

TBR=pdr@chromium.org

Bug:  740879 
Change-Id: Ib16c5a98719ee1059000334e2919ef5743a01426
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/754070
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514875}
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/LayoutTests/platform/mac/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/LayoutTests/platform/win/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/Source/core/frame/Settings.json5
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/Source/core/inspector/DevToolsEmulator.h
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp
[modify] https://crrev.com/cdedc4157e6ed69510703082514039a6d37a1d12/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a

commit de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Wed Nov 08 22:13:42 2017

Revert "Reland "Set proper settings for mobile emulator overlay scrollbar.""

This reverts commit cdedc4157e6ed69510703082514039a6d37a1d12.

Reason for revert: Caused failure on WebKit Android bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/71188

Original change's description:
> Reland "Set proper settings for mobile emulator overlay scrollbar."
> 
> This is a reland of e49403327faee603266393f4ca6ddbd07a6f5a50
> Original change's description:
> > Set proper settings for mobile emulator overlay scrollbar.
> >
> > This issue is caused by mobile emulator does not set proper settings.
> >
> > 1. solid_color_scrollbar need to be true to create animation controller.
> > 2. Need to use correct scrollbar theme for FrameView and PLSA.
> >
> > After this patch, when toggle mobile emulator, scrollbar will paint
> > animating as Android Scrollbar.
> >
> > Bug:  740879 
> > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Change-Id: I2cedba08609e9c0d2f06d26ec2ca92d508f83c48
> > Reviewed-on: https://chromium-review.googlesource.com/646727
> > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> > Reviewed-by: Philip Rogers <pdr@chromium.org>
> > Reviewed-by: David Bokan <bokan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#514085}
> 
> TBR=pdr@chromium.org
> 
> Bug:  740879 
> Change-Id: Ib16c5a98719ee1059000334e2919ef5743a01426
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/754070
> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#514875}

TBR=dgozman@chromium.org,bokan@chromium.org,rprosamaria383@gmail.com,pdr@chromium.org,caseq@chromium.org,pfeldman@chromium.org,chaopeng@chromium.org

Change-Id: Ic9a6ae5c30025e246fa58ac3c02643ea3e7729df
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  740879 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/759239
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514966}
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/LayoutTests/platform/mac/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/LayoutTests/platform/win/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/Source/core/frame/Settings.json5
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/Source/core/inspector/DevToolsEmulator.h
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp
[modify] https://crrev.com/de51caab5ebfaab6ab81ed5f8f20a3dccf4c186a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da60354f49f1167b95a1ac2d80fcd2209c640139

commit da60354f49f1167b95a1ac2d80fcd2209c640139
Author: chaopeng <chaopeng@chromium.org>
Date: Thu Nov 09 22:12:16 2017

Reland "Set proper settings for mobile emulator overlay scrollbar."

This is a reland of e49403327faee603266393f4ca6ddbd07a6f5a50
Original change's description:
> Set proper settings for mobile emulator overlay scrollbar.
>
> This issue is caused by mobile emulator does not set proper settings.
>
> 1. solid_color_scrollbar need to be true to create animation controller.
> 2. Need to use correct scrollbar theme for FrameView and PLSA.
>
> After this patch, when toggle mobile emulator, scrollbar will paint
> animating as Android Scrollbar.
>
> Bug:  740879 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I2cedba08609e9c0d2f06d26ec2ca92d508f83c48
> Reviewed-on: https://chromium-review.googlesource.com/646727
> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#514085}

Bug:  740879 
Change-Id: Ifcf6685ab733fd2745c7b325480b1b3d381bec16
TBR: pdr@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/760596
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515313}
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/LayoutTests/platform/mac/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/LayoutTests/platform/win/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/rtl/overflow-scroll-rtl-expected.png
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/Source/core/frame/Settings.json5
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/Source/core/inspector/DevToolsEmulator.h
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp
[modify] https://crrev.com/da60354f49f1167b95a1ac2d80fcd2209c640139/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h

Comment 16 by chaopeng@chromium.org, Nov 10 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment