CryptoKey: Change |usages|' IDL type |
||||
Issue description
CryptoKey.usages is currently declared as
// TODO(jyasskin): |usages| should be of type object.
readonly attribute DOMString[] usages;
as the comment states, the spec currently uses "object" instead of "DOMString[]".
I'd like to remove support for WebIDL arrays (such as "DOMString[]") from Blink, as they were dropped from the spec in 2015, and before that we need to remove existing uses of arrays in the IDL files.
,
Jul 11 2017
I'm not sure why I wound up on that TODO.
,
Jul 11 2017
Will you change DOMString[] to sequence<DOMString> ?
,
Jul 12 2017
Attempt to remove it here: https://chromium-review.googlesource.com/c/567638/
,
Jul 12 2017
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b7b75b17f28f8a81729e758147d812469dd9cae commit 8b7b75b17f28f8a81729e758147d812469dd9cae Author: Eric Roman <eroman@chromium.org> Date: Wed Jul 12 06:20:11 2017 Make CryptoKey bindings return an object instead of DomString[]. Bug: 740871 Change-Id: I8571bf9448da2a257c45da7f1943226095ab08b7 Reviewed-on: https://chromium-review.googlesource.com/567638 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485877} [modify] https://crrev.com/8b7b75b17f28f8a81729e758147d812469dd9cae/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp [modify] https://crrev.com/8b7b75b17f28f8a81729e758147d812469dd9cae/third_party/WebKit/Source/modules/crypto/CryptoKey.cpp [modify] https://crrev.com/8b7b75b17f28f8a81729e758147d812469dd9cae/third_party/WebKit/Source/modules/crypto/CryptoKey.h [modify] https://crrev.com/8b7b75b17f28f8a81729e758147d812469dd9cae/third_party/WebKit/Source/modules/crypto/CryptoKey.idl
,
Jul 12 2017
That was fast, thanks a lot for the work!
,
Jul 12 2017
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52a5c4b920b5050134852254e15398598c0359c5 commit 52a5c4b920b5050134852254e15398598c0359c5 Author: Eric Roman <eroman@chromium.org> Date: Thu Jul 13 01:21:15 2017 Use the ToV8() overload that takes ScriptState for CryptoKey. Bug: 740871 Change-Id: Ica5bcd76a3f2995a8f414c80698e468f8780734c Reviewed-on: https://chromium-review.googlesource.com/568595 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486200} [modify] https://crrev.com/52a5c4b920b5050134852254e15398598c0359c5/third_party/WebKit/Source/modules/crypto/CryptoKey.cpp |
||||
►
Sign in to add a comment |
||||
Comment 1 by raphael....@intel.com
, Jul 11 2017