URL Elements Popup/Preview of url incorrectly parsed with credentials
Reported by
wormssm...@gmail.com,
Jul 11 2017
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Steps to reproduce the problem: 1. have src/href url with credentials (https://a:b@somedomain.com/image.jpg) 2. hover over url in Dev-Tool's Elements panel 3. Profit. What is the expected behavior? To see https://a:b@somedomain.com/image.jpg in the popup. What went wrong? You see https://currentdomain.com/https:/a:b@somedomain.com/image.jpg Notice its prepended your current domain (or file:// blar blar) to the start and also removed one of the slashes from the original protocol address. https://a:b to https:/a:b Did this work before? N/A Chrome version: 58.0.3029.110 Channel: canary OS Version: 10.0 Flash Version: Fails to work in both stable 58.0.3029.110 (64-bit) and Version 61.0.3154.0 (Official Build) canary (64-bit) Those were the limits of versions easily I have access too. I have hosted the file on https://wormss.net/urlfail.html too. It is identical to the urlfail.html attached. Depending on what you feel more comfortable with.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16e29e6c1ac484780158ecc04af3315c075d1737 commit 16e29e6c1ac484780158ecc04af3315c075d1737 Author: Alexei Filippov <alph@chromium.org> Date: Fri Jul 14 01:25:17 2017 DevTools: Support user credentials in ParsedURL Bug: 740858 Change-Id: Idd363c00328603f20c4bb916fc83be8bea6ee5c3 Reviewed-on: https://chromium-review.googlesource.com/570626 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#486600} [modify] https://crrev.com/16e29e6c1ac484780158ecc04af3315c075d1737/third_party/WebKit/LayoutTests/inspector/components/parsed-url-expected.txt [modify] https://crrev.com/16e29e6c1ac484780158ecc04af3315c075d1737/third_party/WebKit/LayoutTests/inspector/components/parsed-url.html [modify] https://crrev.com/16e29e6c1ac484780158ecc04af3315c075d1737/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js
,
Jul 19 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by alph@chromium.org
, Jul 13 2017Status: Assigned (was: Unconfirmed)