New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740857 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Unnecessary bookmarked url chip is seen and gets stucked after drag & drop on 'Edit' bookmark overlay

Reported by abom...@etouch.net, Jul 11 2017

Issue description

Chrome Version:61.0.3153.0 (Official Build)4b9102f9588fb6cf639a6165fd4777658d5ade0d-refs/heads/master@{#485143} 32/64-bit
OS : Windows(7,8,10), Linux(14.04 LTS), Mac(10.11.6, 10.12.3)

Pre-condition: Bookmark 3-4 websites.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://bookmarks/?id=1
2. Click on 'More actions' icon and select 'Edit' such that 'Edit' overlay is seen.
3. Try to drag omnibox url and drop on 'Name' field or 'Url' field of Edit overlay.(refer screencast)
4. Observe drag&drop chip of bookmarked url.

Actual:Unnecessary bookmarked url chip is seen and gets stucked after step 3.
Expected: Drag and drop chip should not be seen on background page and also not get stuck behind the overlay momentarily

This is non-regression issue seen from ‘M 61’ (61.0.3149.0) newly added feature.

 
Actual_chip.mp4
1.0 MB View Download
Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b19fa87f981ce227433d03283bf8175d1c29742f

commit b19fa87f981ce227433d03283bf8175d1c29742f
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Jul 24 04:45:18 2017

[MD Bookmarks] Use mouse events for internal drags.

This CL separates internal and external drags to use mouse events and
native drag respectively. This provides a more reliable internal drag
experience, and fixes an issue where the native drag would place a drag
image over the bookmark chip.

Bug:  739271 ,  740857 ,  745347 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I930d11e8f063d5483fe4c0f38785eff94c8b1a33
Reviewed-on: https://chromium-review.googlesource.com/576009
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488912}
[modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/chrome/browser/resources/md_bookmarks/util.js
[modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
[modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/chrome/test/data/webui/md_history/history_synced_tabs_test.js
[modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/third_party/polymer/v1_0/components-chromium/iron-test-helpers/bower.json
[modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/third_party/polymer/v1_0/components-chromium/iron-test-helpers/mock-interactions.js
[modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/third_party/polymer/v1_0/components-chromium/iron-test-helpers/test-helpers.js
[modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/third_party/polymer/v1_0/components_summary.txt

Fixed?
Owner: calamity@chromium.org
Status: Fixed (was: Untriaged)
Oops. Yes.

PS: This was a nightmare.

Sign in to add a comment