New issue
Advanced search Search tips

Issue 740853 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 770046



Sign in to add a comment

Incorrect domain rendered on chrome://settings/passwords

Project Member Reported by vasi...@chromium.org, Jul 11 2017

Issue description

Chrome Version: 61.0.3149.0 (Developer Build) (64-bit)
OS: desktop

What steps will reproduce the problem?
(1) Visit http://1.chromium-test1.appspot.com/testing/psl-matching/login
(2) Login and save the password
(3) Go to chrome://settings/passwords

What is the expected result?
The website column should display '1.chromium-test1.appspot.com'

What happens instead?
'chromium-test1.appspot.com.1' is rendered. Also try to select the domain by mouse from the left to right.
 
Screenshot from 2017-07-11 11:08:23.png
9.5 KB View Download
Status: Started (was: Untriaged)
This is b/c of RTL for eliding.... :-\ I'm looking into this to see what we can do to display correctly and elide from the left
Just as an FYI: this was broken in old settings too :-(
Old passwords.png
17.6 KB View Download
I played a bit around with this, and it seems like wrapping [[item.loginPair.urls.shown]] in <bdo dir=ltr>...</bdo> might solve the issue, while keeping left eliding for long origins. See the attached screenshot as an example.

This solution is not very pretty, but it might just work. What do you think, hcarmona@?
Elide_Origins.png
17.0 KB View Download

Comment 4 by dpa...@chromium.org, Jul 25 2017

Labels: Proj-MaterialDesign-WebUI
Cc: -jdoerrie@chromium.org hcarmona@chromium.org
Owner: jdoerrie@chromium.org
That sounds good, feel free to send CL my way for review. Assigned bug to you since you've got the solution :-)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8829b2b26b68d19f07b61754af0230bd3b71df5d

commit 8829b2b26b68d19f07b61754af0230bd3b71df5d
Author: jdoerrie <jdoerrie@chromium.org>
Date: Sat Jul 29 06:31:08 2017

Fix Display of Origins with Leading Numbers

This change fixes the display of origins with leading numbers by adding
an appropriate bidirectional override tag.

Bug: 740853
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I662c5505a2043e6ee03ddde2ca8a42c4b6729768
Reviewed-on: https://chromium-review.googlesource.com/585532
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490637}
[modify] https://crrev.com/8829b2b26b68d19f07b61754af0230bd3b71df5d/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html

Labels: TE-Verified-62.0.3172.0 TE-Verified-M62
Tested the issue on Mac OS 10.12.6, Ubuntu 14.04 and Windows 7 using Chrome Canary version M62 - 62.0.3172.0 as per the issue mentioned in original comment. Observed that issue is working as intended (URL is rendered as expected). Hence adding TE-Verified label.

Please find the screenshot for reference.

Thank you!
740853.png
6.3 KB View Download
Status: Fixed (was: Started)
Cc: mkarkada@chromium.org dhadd...@chromium.org
I am not getting the intended result as in #1, but the actual result displays the url of the website when hovered over the item in chrome://settings/passwords.

If this result fulfills the bug, then only I will proceed with closing this bug.
Tested on Chrome OS 9824.0.0, 62.0.3176.0 dev build.

Please refer the screenshot for output.
Screenshot 2017-08-09 at 5.28.38 PM.png
258 KB View Download
Status: Assigned (was: Fixed)
Reopening the bug as per c#9. The website name starts with "..chromium-test1" (as in the screenshot above), instead of "1.chromium-test1". 
Tested on ChromeOS M62 9901.66.0, 62.0.3202.82

Comment 11 by kolos@chromium.org, Jan 26 2018

Blocking: 770046

Sign in to add a comment