New issue
Advanced search Search tips

Issue 740845 link

Starred by 2 users
Status: Fixed
Owner:
perezju@chromium.org
Closed: Jul 2017
Cc:
simonhatch@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 739775



Sign in to add a comment

Webview try bots are not running webview

Project Member Reported by perezju@chromium.org, Jul 11 2017 
I ran a couple of try jobs here:

https://luci-milo.appspot.com/buildbot/tryserver.chromium.perf/android_webview_arm64_aosp_perf_bisect/1481

https://luci-milo.appspot.com/buildbot/tryserver.chromium.perf/android_webview_nexus6_aosp_perf_bisect/1024

Using the command:

$ tools/perf/run_benchmark try android-webview-nexus6-aosp memory.top_10_mobile --pageset-repeat 10

Their perf_try_config however shows:

{"command":"src/tools/perf/run_benchmark --browser=android-chromium memory.top_10_mobile --pageset-repeat 10 ...
                                                   ^^^^ - should be webview

+simon could you triage?

Comment 1 by simonhatch@chromium.org, Jul 11 2017

Components: Speed>Bisection
Hmm I'm pretty sure this is guessed in trybot_command.py

https://cs.chromium.org/chromium/src/tools/perf/core/trybot_command.py?q=trybot_comm&sq=package:chromium&l=426

We could insert a check in there, won't be pretty but should work until we route these to pinpoint which should know how this kinda stuff.

Comment 2 by perezju@chromium.org, Jul 12 2017

Owner: perezju@chromium.org
Status: Assigned (was: Untriaged)
Ok, I'll do that fix.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dbc6e296639e741161064f0ab9112bae40a4680

commit 6dbc6e296639e741161064f0ab9112bae40a4680
Author: Juan A. Navarro Perez <perezju@chromium.org>
Date: Fri Jul 14 11:20:12 2017

[tools/perf] Use correct browser for try jobs on webview bots

Use --browser=android-webview on trybot command when selected bots
include webview.

NOTRY=True

Bug:  740845 
Change-Id: Ib1d7f436a6d290a9cb63a3f7aaebfb92581e07d8
Reviewed-on: https://chromium-review.googlesource.com/567933
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486734}
[modify] https://crrev.com/6dbc6e296639e741161064f0ab9112bae40a4680/tools/perf/core/trybot_command.py
[modify] https://crrev.com/6dbc6e296639e741161064f0ab9112bae40a4680/tools/perf/core/trybot_command_unittest.py

Comment 4 by perezju@chromium.org, Jul 14 2017

Status: Fixed (was: Assigned)
This should be fixed now.
►

Sign in to add a comment