Add tool bar button to open context menu for current selection |
||||||
Issue descriptionThis is a part of Issue 730232 . > 2. Increase discoverability of the context menu in touch mode. We'll add a new button to the tool bar which appears while in the check-select mode. The button itself is not dependent on the touch UI. It should also be usable by mouse and keyboard operations. The context menu shown by the button should not have duplicated items with other buttons in the action bar.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f70200fde205d982dd10722fbeef1309eae22b6e commit f70200fde205d982dd10722fbeef1309eae22b6e Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Fri Jul 14 09:54:37 2017 Files app: Add a toolbar button to show some context menu items. This change will only add these items: - Cut, Copy - zip selection "Available offline" is not refreshed in some cases. "Get info" and "Rename" is not added by this change. Those should be fixed by another change. TEST=manually tested by check-select files and opening the menu Bug: 740842 Change-Id: Ic074b3b38eddf5c1bd9d8ae162e5c0d24bb17c8e Reviewed-on: https://chromium-review.googlesource.com/566768 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#486715} [modify] https://crrev.com/f70200fde205d982dd10722fbeef1309eae22b6e/ui/file_manager/file_manager/foreground/css/file_manager.css [add] https://crrev.com/f70200fde205d982dd10722fbeef1309eae22b6e/ui/file_manager/file_manager/foreground/images/files/ui/2x/menu.png [add] https://crrev.com/f70200fde205d982dd10722fbeef1309eae22b6e/ui/file_manager/file_manager/foreground/images/files/ui/menu.png [modify] https://crrev.com/f70200fde205d982dd10722fbeef1309eae22b6e/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp [modify] https://crrev.com/f70200fde205d982dd10722fbeef1309eae22b6e/ui/file_manager/file_manager/foreground/js/file_manager.js [modify] https://crrev.com/f70200fde205d982dd10722fbeef1309eae22b6e/ui/file_manager/file_manager/foreground/js/main_scripts.js [add] https://crrev.com/f70200fde205d982dd10722fbeef1309eae22b6e/ui/file_manager/file_manager/foreground/js/selection_menu_controller.js [modify] https://crrev.com/f70200fde205d982dd10722fbeef1309eae22b6e/ui/file_manager/file_manager/foreground/js/ui/actions_submenu.js [modify] https://crrev.com/f70200fde205d982dd10722fbeef1309eae22b6e/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js [modify] https://crrev.com/f70200fde205d982dd10722fbeef1309eae22b6e/ui/file_manager/file_manager/main.html
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f657186c6605aa268a8f5bc12d46516fa68c8ef commit 1f657186c6605aa268a8f5bc12d46516fa68c8ef Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Fri Jul 14 11:17:20 2017 Serve "Get Info" command from the toolbar menu button. TEST=manually tested get-info command enabled for single selection and disabled for multiple selection TEST=manually tested chrome://histograms records the new way to open QuickView as #2. Bug: 740842 Change-Id: I3c9d58f7d3877e7b059bb386a56cdc8d4e54a43b Reviewed-on: https://chromium-review.googlesource.com/571380 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#486732} [modify] https://crrev.com/1f657186c6605aa268a8f5bc12d46516fa68c8ef/tools/metrics/histograms/enums.xml [modify] https://crrev.com/1f657186c6605aa268a8f5bc12d46516fa68c8ef/ui/file_manager/file_manager/foreground/js/file_manager.js [modify] https://crrev.com/1f657186c6605aa268a8f5bc12d46516fa68c8ef/ui/file_manager/file_manager/foreground/js/file_manager_commands.js [modify] https://crrev.com/1f657186c6605aa268a8f5bc12d46516fa68c8ef/ui/file_manager/file_manager/foreground/js/quick_view_controller.js [modify] https://crrev.com/1f657186c6605aa268a8f5bc12d46516fa68c8ef/ui/file_manager/file_manager/foreground/js/quick_view_uma.js
,
Jul 14 2017
paste-into-folder, rename, and set-wallpaper commands also need changes to accept selected file instead of event target. It can be done in a similar way to the change for get-info command mentioned in #3.
,
Jul 19 2017
,
Jul 19 2017
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fe34c99adeae75b6a737059c2760a4575fa8c86 commit 2fe34c99adeae75b6a737059c2760a4575fa8c86 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Jul 20 08:00:48 2017 Allow set-wallpaper command in the toolbar button menu. Bug: 740842 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8a0826a93cb36588bda03b5acfbf633c35d8d11e Reviewed-on: https://chromium-review.googlesource.com/577978 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#488161} [modify] https://crrev.com/2fe34c99adeae75b6a737059c2760a4575fa8c86/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4617edbe854722f25754ff6d5dc739fad1ca8aea commit 4617edbe854722f25754ff6d5dc739fad1ca8aea Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Jul 20 08:11:37 2017 Allow rename command for a selected file by the toolbar button menu. Bug: 740842 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia7513ab41b6e684fec446d4f6232b4e29f09b0f5 Reviewed-on: https://chromium-review.googlesource.com/577975 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#488166} [modify] https://crrev.com/4617edbe854722f25754ff6d5dc739fad1ca8aea/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
,
Jul 20 2017
,
Jul 28 2017
Verified on chrome os 9765.9.0, 61.0.3163.16 dev build. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by weifangsun@chromium.org
, Jul 11 2017